Re: [PATCH net-next 2/4] net: systemport: use the new fixed PHY helpers

2014-05-19 13:19 GMT-07:00 Thomas Petazzoni
[off-list ref]:

Dear Florian Fainelli,

On Mon, 19 May 2014 12:43:43 -0700, Florian Fainelli wrote:

quoted

+     priv->phydev = of_phy_connect(dev, priv->phy_dn, bcm_sysport_adj_link,
+                                     0, priv->phy_interface);
      if (!priv->phydev) {
              netdev_err(dev, "could not attach to PHY\n");
              return -ENODEV;

@@ -1551,6 +1551,20 @@ static int bcm_sysport_probe(struct platform_device *pdev)
      if (priv->phy_interface < 0)
              priv->phy_interface = PHY_INTERFACE_MODE_GMII;

+     /* SYSTEMPORT uses the old 'fixed-link' 5-digit property which is
+      * deprecated, we need to register the fixed PHY using the Ethernet
+      * MAC node since we do not have a 'fixed-link' subnode.
+      */

Actually even if you use the new fixed PHY DT binding, the DT node
linked to the PHY is the Ethernet MAC node. This is because I didn't
want to have a difference between how things are handled between the
old and the new binding.

Sure, I agree, and the comment still stands, I am just expressing it
that we are not looking for the 'fixed-link' subnode, but the
'fixed-link' 5-digit property here. Would you want me to rephrase
that?
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Dear Florian Fainelli,

On Mon, 19 May 2014 14:52:57 -0700, Florian Fainelli wrote:

quoted

quoted

+     /* SYSTEMPORT uses the old 'fixed-link' 5-digit property which is
+      * deprecated, we need to register the fixed PHY using the Ethernet
+      * MAC node since we do not have a 'fixed-link' subnode.
+      */

Actually even if you use the new fixed PHY DT binding, the DT node
linked to the PHY is the Ethernet MAC node. This is because I didn't
want to have a difference between how things are handled between the
old and the new binding.

Sure, I agree, and the comment still stands, I am just expressing it
that we are not looking for the 'fixed-link' subnode, but the
'fixed-link' 5-digit property here. Would you want me to rephrase
that?

What I found misleading in the comment is that you simply to imply that
because you're not using the new DT binding for fixed-link, the DT node
that is associated to the PHY is the Ethernet MAC.

The truth is that the DT node associated to the fixed PHY is always the
Ethernet MAC, regardless of whether you're using the old or the new DT
binding.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com