[PATCH] rds/tcp_listen: Replace comma with semicolon

Subsystems: networking [general], rds - reliable datagram sockets, the rest

STALE4492d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2014-05-31 · open the first message on its own page

[PATCH] rds/tcp_listen: Replace comma with semicolon

From: Himangi Saraogi <hidden>
Date: 2014-05-30 15:47:33

This patch replaces a comma between expression statements by a semicolon.

A simplified version of the semantic patch that performs this
transformation is as follows:

// <smpl>
@r@
expression e1,e2,e;
type T;
identifier i;
@@

 e1
-,
+;
 e2;
// </smpl>

Signed-off-by: Himangi Saraogi <redacted>
Acked-by: Julia Lawall <redacted>
---
 net/rds/tcp_listen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c
index 4e638f8..23ab4dcd 100644
--- a/net/rds/tcp_listen.c
+++ b/net/rds/tcp_listen.c
@@ -153,7 +153,7 @@ int rds_tcp_listen_init(void)
 	sock->sk->sk_data_ready = rds_tcp_listen_data_ready;
 	write_unlock_bh(&sock->sk->sk_callback_lock);
 
-	sin.sin_family = PF_INET,
+	sin.sin_family = PF_INET;
 	sin.sin_addr.s_addr = (__force u32)htonl(INADDR_ANY);
 	sin.sin_port = (__force u16)htons(RDS_TCP_PORT);
 
-- 
1.9.1

Re: [PATCH] rds/tcp_listen: Replace comma with semicolon

From: David Miller <davem@davemloft.net>
Date: 2014-05-31 00:50:05

From: Himangi Saraogi <redacted>
Date: Fri, 30 May 2014 21:17:13 +0530
This patch replaces a comma between expression statements by a semicolon.

A simplified version of the semantic patch that performs this
transformation is as follows:
 ...
Signed-off-by: Himangi Saraogi <redacted>
Acked-by: Julia Lawall <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help