[PATCH] mrf24j40: add managed API's provided by device layer

Subsystems: ieee 802.15.4 subsystem, mrf24j40 ieee 802.15.4 radio driver, networking drivers, the rest

STALE4482d

2 messages, 2 authors, 2014-05-29 · open the first message on its own page

[PATCH] mrf24j40: add managed API's provided by device layer

From: Varka Bhadram <hidden>
Date: 2014-05-29 04:18:52 

This patch adds the managed APIs to the deriver code. By using this we need
not to worry about freeing the memory and irq numbers.

Thanks and Regards,
Varka Bhadram

Signed-off-by: Varka Bhadram <redacted>
---
 drivers/net/ieee802154/mrf24j40.c |   22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index 78a6552..729ec0f 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -618,10 +618,11 @@ static int mrf24j40_probe(struct spi_device *spi)
 
 	printk(KERN_INFO "mrf24j40: probe(). IRQ: %d\n", spi->irq);
 
-	devrec = kzalloc(sizeof(struct mrf24j40), GFP_KERNEL);
+	devrec = devm_kzalloc(spi->dev,
+			sizeof(struct mrf24j40), GFP_KERNEL);
 	if (!devrec)
 		goto err_devrec;
-	devrec->buf = kzalloc(3, GFP_KERNEL);
+	devrec->buf = devm_kzalloc(spi->dev, 3, GFP_KERNEL);
 	if (!devrec->buf)
 		goto err_buf;
 
@@ -676,12 +677,13 @@ static int mrf24j40_probe(struct spi_device *spi)
 	val &= ~0x3; /* Clear RX mode (normal) */
 	write_short_reg(devrec, REG_RXMCR, val);
 
-	ret = request_threaded_irq(spi->irq,
-				   NULL,
-				   mrf24j40_isr,
-				   IRQF_TRIGGER_LOW|IRQF_ONESHOT,
-				   dev_name(&spi->dev),
-				   devrec);
+	ret = devm_request_threaded_irq(spi->dev,
+					spi->irq,
+					NULL,
+					mrf24j40_isr,
+					IRQF_TRIGGER_LOW|IRQF_ONESHOT,
+					dev_name(&spi->dev),
+					devrec);
 
 	if (ret) {
 		dev_err(printdev(devrec), "Unable to get IRQ");
@@ -709,15 +711,11 @@ static int mrf24j40_remove(struct spi_device *spi)
 
 	dev_dbg(printdev(devrec), "remove\n");
 
-	free_irq(spi->irq, devrec);
 	ieee802154_unregister_device(devrec->dev);
 	ieee802154_free_device(devrec->dev);
 	/* TODO: Will ieee802154_free_device() wait until ->xmit() is
 	 * complete? */
 
-	/* Clean up the SPI stuff. */
-	kfree(devrec->buf);
-	kfree(devrec);
 	return 0;
 }
 
-- 
1.7.9.5

Re: [PATCH] mrf24j40: add managed API's provided by device layer

From: Sergei Shtylyov <hidden>
Date: 2014-05-29 17:45:32 

Hello.

On 05/29/2014 08:17 AM, Varka Bhadram wrote:

This patch adds the managed APIs to the deriver code. By using this we need
not to worry about freeing the memory and irq numbers.
Thanks and Regards,
Varka Bhadram
    This is not desirable thing in the patch changelog, maintainer will have 
to edit it out...

Signed-off-by: Varka Bhadram <redacted>
---
  drivers/net/ieee802154/mrf24j40.c |   22 ++++++++++------------
  1 file changed, 10 insertions(+), 12 deletions(-)
quoted hunk
diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index 78a6552..729ec0f 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -618,10 +618,11 @@ static int mrf24j40_probe(struct spi_device *spi)

  	printk(KERN_INFO "mrf24j40: probe(). IRQ: %d\n", spi->irq);

-	devrec = kzalloc(sizeof(struct mrf24j40), GFP_KERNEL);
+	devrec = devm_kzalloc(spi->dev,
+			sizeof(struct mrf24j40), GFP_KERNEL);
    Continuation line should start under the next character after ( on the 
previous line, according to the networking coding style.

[...]

WBR, Sergei




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help