[PATCH 0/2] drivers/net: Remove trailing semicolons from do {...} while 0 macros

STALE4508d

4 messages, 2 authors, 2014-05-15 · open the first message on its own page

[PATCH 0/2] drivers/net: Remove trailing semicolons from do {...} while 0 macros

From: Joe Perches <joe@perches.com>
Date: 2014-05-14 19:15:21

Joe Perches (2):
  ti: Remove trailing semicolon from do {...} while (0) macro
  wlcore: Remove trailing semicolon from do {...} while (0) macro

 drivers/net/ethernet/ti/cpsw.c           | 4 ++--
 drivers/net/wireless/ti/wlcore/debugfs.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
1.8.1.2.459.gbcd45b4.dirty

[PATCH 2/2] wlcore: Remove trailing semicolon from do {...} while (0) macro

From: Joe Perches <joe@perches.com>
Date: 2014-05-14 19:15:28

These should not have trailing semicolons so remove them.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/wireless/ti/wlcore/debugfs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/debugfs.h b/drivers/net/wireless/ti/wlcore/debugfs.h
index f7381dd..0f2cfb0 100644
--- a/drivers/net/wireless/ti/wlcore/debugfs.h
+++ b/drivers/net/wireless/ti/wlcore/debugfs.h
@@ -57,7 +57,7 @@ static const struct file_operations name## _ops = {			\
 					    wl, &name## _ops);		\
 		if (!entry || IS_ERR(entry))				\
 			goto err;					\
-	} while (0);
+	} while (0)
 
 
 #define DEBUGFS_ADD_PREFIX(prefix, name, parent)			\
@@ -66,7 +66,7 @@ static const struct file_operations name## _ops = {			\
 				    wl, &prefix## _## name## _ops);	\
 		if (!entry || IS_ERR(entry))				\
 			goto err;					\
-	} while (0);
+	} while (0)
 
 #define DEBUGFS_FWSTATS_FILE(sub, name, fmt, struct_type)		\
 static ssize_t sub## _ ##name## _read(struct file *file,		\
-- 
1.8.1.2.459.gbcd45b4.dirty

[PATCH 1/2] ti: Remove trailing semicolon from do {...} while (0) macro

From: Joe Perches <joe@perches.com>
Date: 2014-05-14 19:15:30

These should not have trailing semicolons so remove them.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/ethernet/ti/cpsw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index e3d8710..da57d33 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -143,13 +143,13 @@ do {								\
 		u32 i;		\
 		for (i = 0; i < priv->num_irqs; i++) \
 			enable_irq(priv->irqs_table[i]); \
-	} while (0);
+	} while (0)
 #define cpsw_disable_irq(priv)	\
 	do {			\
 		u32 i;		\
 		for (i = 0; i < priv->num_irqs; i++) \
 			disable_irq_nosync(priv->irqs_table[i]); \
-	} while (0);
+	} while (0)
 
 #define cpsw_slave_index(priv)				\
 		((priv->data.dual_emac) ? priv->emac_port :	\
-- 
1.8.1.2.459.gbcd45b4.dirty

Re: [PATCH 1/2] ti: Remove trailing semicolon from do {...} while (0) macro

From: David Miller <davem@davemloft.net>
Date: 2014-05-15 20:41:54

From: Joe Perches <joe@perches.com>
Date: Wed, 14 May 2014 12:15:13 -0700
These should not have trailing semicolons so remove them.

Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help