randconfig build error with next-20140502, in drivers/net/hyperv/netvsc_drv.c

Building with the attached random configuration file,

drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_recv_callback’:
drivers/net/hyperv/netvsc_drv.c:648:11: error: ‘struct net_device’ has no member
 named ‘real_num_rx_queues’
        net->real_num_rx_queues);
           ^
In file included from drivers/net/hyperv/netvsc_drv.c:26:0:
drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_probe’:
drivers/net/hyperv/netvsc_drv.c:832:32: error: ‘struct net_device’ has
no member named ‘real_num_rx_queues’
    net->real_num_tx_queues, net->real_num_rx_queues);
                                ^
include/linux/device.h:1080:58: note: in definition of macro ‘dev_info’
 #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
                                                          ^
make[3]: *** [drivers/net/hyperv/netvsc_drv.o] Error 1

-----Original Message-----
From: Haiyang Zhang
Sent: Friday, May 2, 2014 7:42 AM
To: Jim Davis; Stephen Rothwell; linux-next; linux-kernel; KY Srinivasan;
devel@linuxdriverproject.org; netdev
Subject: RE: randconfig build error with next-20140502, in
drivers/net/hyperv/netvsc_drv.c

quoted

-----Original Message-----
From: Jim Davis [mailto:jim.epost@gmail.com]
Sent: Friday, May 2, 2014 9:56 AM
To: Stephen Rothwell; linux-next; linux-kernel; KY Srinivasan; Haiyang
Zhang; devel@linuxdriverproject.org; netdev
Subject: randconfig build error with next-20140502, in
drivers/net/hyperv/netvsc_drv.c

Building with the attached random configuration file,

drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_recv_callback’:
drivers/net/hyperv/netvsc_drv.c:648:11: error: ‘struct net_device’ has
no member  named ‘real_num_rx_queues’
        net->real_num_rx_queues);
           ^
In file included from drivers/net/hyperv/netvsc_drv.c:26:0:
drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_probe’:
drivers/net/hyperv/netvsc_drv.c:832:32: error: ‘struct net_device’ has
no member named ‘real_num_rx_queues’
    net->real_num_tx_queues, net->real_num_rx_queues);
                                ^
include/linux/device.h:1080:58: note: in definition of macro ‘dev_info’
 #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
                                                          ^
make[3]: *** [drivers/net/hyperv/netvsc_drv.o] Error 1

real_num_rx_queues is defined in "include/linux/netdevice.h":
It requires CONFIG_SYSFS flag, which is enabled by default, but not set in
your config file.

Could you use default config and add hyperv drivers, then try again?

Haiyang,

That is the point - the code must compile correctly for all possible configurations.
You will want to protect the dependencies appropriately.

K. Y

Thanks,
- Haiyang

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

-----Original Message-----
From: Jim Davis [mailto:jim.epost@gmail.com]
Sent: Friday, May 2, 2014 9:56 AM
To: Stephen Rothwell; linux-next; linux-kernel; KY Srinivasan; Haiyang
Zhang; devel@linuxdriverproject.org; netdev
Subject: randconfig build error with next-20140502, in
drivers/net/hyperv/netvsc_drv.c

Building with the attached random configuration file,

drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_recv_callback’:
drivers/net/hyperv/netvsc_drv.c:648:11: error: ‘struct net_device’ has
no member
 named ‘real_num_rx_queues’
        net->real_num_rx_queues);
           ^
In file included from drivers/net/hyperv/netvsc_drv.c:26:0:
drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_probe’:
drivers/net/hyperv/netvsc_drv.c:832:32: error: ‘struct net_device’ has
no member named ‘real_num_rx_queues’
    net->real_num_tx_queues, net->real_num_rx_queues);
                                ^
include/linux/device.h:1080:58: note: in definition of macro ‘dev_info’
 #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
                                                          ^
make[3]: *** [drivers/net/hyperv/netvsc_drv.o] Error 1

real_num_rx_queues is defined in "include/linux/netdevice.h":
It requires CONFIG_SYSFS flag, which is enabled by default, but not set in 
your config file.

Could you use default config and add hyperv drivers, then try again?

Thanks,
- Haiyang

-----Original Message-----
From: KY Srinivasan
Sent: Friday, May 2, 2014 11:00 AM
To: Haiyang Zhang; Jim Davis; Stephen Rothwell; linux-next; linux-kernel;
devel@linuxdriverproject.org; netdev
Subject: RE: randconfig build error with next-20140502, in
drivers/net/hyperv/netvsc_drv.c

quoted

-----Original Message-----
From: Haiyang Zhang
Sent: Friday, May 2, 2014 7:42 AM
To: Jim Davis; Stephen Rothwell; linux-next; linux-kernel; KY

Srinivasan;

quoted

devel@linuxdriverproject.org; netdev
Subject: RE: randconfig build error with next-20140502, in
drivers/net/hyperv/netvsc_drv.c

quoted

-----Original Message-----
From: Jim Davis [mailto:jim.epost@gmail.com]
Sent: Friday, May 2, 2014 9:56 AM
To: Stephen Rothwell; linux-next; linux-kernel; KY Srinivasan;

Haiyang

quoted

quoted

Zhang; devel@linuxdriverproject.org; netdev
Subject: randconfig build error with next-20140502, in
drivers/net/hyperv/netvsc_drv.c

Building with the attached random configuration file,

drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_recv_callback’:
drivers/net/hyperv/netvsc_drv.c:648:11: error: ‘struct net_device’

has

quoted

quoted

no member  named ‘real_num_rx_queues’
        net->real_num_rx_queues);
           ^
In file included from drivers/net/hyperv/netvsc_drv.c:26:0:
drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_probe’:
drivers/net/hyperv/netvsc_drv.c:832:32: error: ‘struct net_device’

has

quoted

quoted

no member named ‘real_num_rx_queues’
    net->real_num_tx_queues, net->real_num_rx_queues);
                                ^
include/linux/device.h:1080:58: note: in definition of macro

‘dev_info’

quoted

quoted

 #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
                                                          ^
make[3]: *** [drivers/net/hyperv/netvsc_drv.o] Error 1

real_num_rx_queues is defined in "include/linux/netdevice.h":
It requires CONFIG_SYSFS flag, which is enabled by default, but not

set in

quoted

your config file.

Could you use default config and add hyperv drivers, then try again?

Haiyang,

That is the point - the code must compile correctly for all possible
configurations.
You will want to protect the dependencies appropriately.

OK, I'll look into this.

Thanks,
- Haiyang

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri, 2 May 2014 14:42:06 +0000

real_num_rx_queues is defined in "include/linux/netdevice.h":
It requires CONFIG_SYSFS flag, which is enabled by default, but not set in 
your config file.

Could you use default config and add hyperv drivers, then try again?

You must fix your driver to compile successfully under all possible
configuration combinations, not just the ones which are convenient
for you to support.

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Friday, May 2, 2014 3:19 PM
To: Haiyang Zhang
Cc: jim.epost@gmail.com; sfr@canb.auug.org.au; linux-
next@vger.kernel.org; linux-kernel@vger.kernel.org; KY Srinivasan;
devel@linuxdriverproject.org; netdev@vger.kernel.org
Subject: Re: randconfig build error with next-20140502, in
drivers/net/hyperv/netvsc_drv.c

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri, 2 May 2014 14:42:06 +0000

quoted

real_num_rx_queues is defined in "include/linux/netdevice.h":
It requires CONFIG_SYSFS flag, which is enabled by default, but not

set in

quoted

your config file.

Could you use default config and add hyperv drivers, then try again?

You must fix your driver to compile successfully under all possible
configuration combinations, not just the ones which are convenient
for you to support.

OK, I'll look into this.

Thanks,
- Haiyang

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Friday, May 2, 2014 3:19 PM
To: Haiyang Zhang
Cc: jim.epost@gmail.com; sfr@canb.auug.org.au; linux-next@vger.kernel.org;
linux-kernel@vger.kernel.org; KY Srinivasan; devel@linuxdriverproject.org;
netdev@vger.kernel.org
Subject: Re: randconfig build error with next-20140502, in
drivers/net/hyperv/netvsc_drv.c

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri, 2 May 2014 14:42:06 +0000

quoted

real_num_rx_queues is defined in "include/linux/netdevice.h":
It requires CONFIG_SYSFS flag, which is enabled by default, but not
set in your config file.

Could you use default config and add hyperv drivers, then try again?

You must fix your driver to compile successfully under all possible configuration
combinations, not just the ones which are convenient for you to support.

I have submitted a patch to support compiling it without CONFIG_SYSFS flag.

Thanks,
- Haiyang