Found some errors and other oddities, largely by means of a static code analysis program
From: Rickard Strandqvist <hidden>
Date: 2014-05-03 15:17:50
Attachments
- drivers_isdn_3files.patch [text/x-patch] 2270 bytes · preview
From: Rickard Strandqvist <hidden>
Date: 2014-05-03 15:17:50
Hello again Sorry! I failed to include the patch :-) The static code analysis program called cppcheck. http://cppcheck.sourceforge.net/ I found code that I think are bugs, or at least inappropriate or unnecessary code, in the files: drivers/isdn/hisax/l3dss1.c drivers/isdn/hisax/l3ni1.c drivers/isdn/mISDN/dsp_cmx.c I have created a patch, and inluderat the error file generated by cppcheck. My goal was not to change any functionality, but it does not mean for example the unused variables can't mean that there are other problems/mistakes in the code. So a proper code review :) Is there anything else I can help with regarding the patch or cppcheck, do not hesitate to contact me. If you like this type of code analysis, it is possible to get more warnings, which are not as serious, but that may well indicate other mistakes. Best regards Rickard Strandqvist