[PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

Subsystems: infiniband subsystem, the rest

STALE4544d

3 messages, 3 authors, 2014-03-19 · open the first message on its own page

[PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

From: Monam Agarwal <hidden>
Date: 2014-03-18 22:03:25

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) in drivers/infiniband/hw/qib/qib_qp.c

Signed-off-by: Monam Agarwal <redacted>
---
 drivers/infiniband/hw/qib/qib_qp.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_qp.c b/drivers/infiniband/hw/qib/qib_qp.c
index 7e7e16f..1f5f04c 100644
--- a/drivers/infiniband/hw/qib/qib_qp.c
+++ b/drivers/infiniband/hw/qib/qib_qp.c

@@ -252,10 +252,10 @@ static void remove_qp(struct qib_ibdev *dev, struct qib_qp *qp)
 
 	if (ibp->qp0 == qp) {
 		atomic_dec(&qp->refcount);
-		rcu_assign_pointer(ibp->qp0, NULL);
+		RCU_INIT_POINTER(ibp->qp0, NULL);
 	} else if (ibp->qp1 == qp) {
 		atomic_dec(&qp->refcount);
-		rcu_assign_pointer(ibp->qp1, NULL);
+		RCU_INIT_POINTER(ibp->qp1, NULL);
 	} else {
 		struct qib_qp *q, **qpp;

@@ -303,7 +303,7 @@ unsigned qib_free_all_qps(struct qib_devdata *dd)
 	spin_lock_irqsave(&dev->qpt_lock, flags);
 	for (n = 0; n < dev->qp_table_size; n++) {
 		qp = dev->qp_table[n];
-		rcu_assign_pointer(dev->qp_table[n], NULL);
+		RCU_INIT_POINTER(dev->qp_table[n], NULL);
 
 		for (; qp; qp = qp->next)
 			qp_inuse++;

-- 
1.7.9.5

Re: [PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

From: Paul E. McKenney <hidden>
Date: 2014-03-18 22:18:31

On Wed, Mar 19, 2014 at 03:32:30AM +0530, Monam Agarwal wrote:

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) in drivers/infiniband/hw/qib/qib_qp.c

Signed-off-by: Monam Agarwal <redacted>

Reviewed-by: Paul E. McKenney <redacted>

quoted hunk

---
 drivers/infiniband/hw/qib/qib_qp.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_qp.c b/drivers/infiniband/hw/qib/qib_qp.c
index 7e7e16f..1f5f04c 100644
--- a/drivers/infiniband/hw/qib/qib_qp.c
+++ b/drivers/infiniband/hw/qib/qib_qp.c

@@ -252,10 +252,10 @@ static void remove_qp(struct qib_ibdev *dev, struct qib_qp *qp)

 	if (ibp->qp0 == qp) {
 		atomic_dec(&qp->refcount);
-		rcu_assign_pointer(ibp->qp0, NULL);
+		RCU_INIT_POINTER(ibp->qp0, NULL);
 	} else if (ibp->qp1 == qp) {
 		atomic_dec(&qp->refcount);
-		rcu_assign_pointer(ibp->qp1, NULL);
+		RCU_INIT_POINTER(ibp->qp1, NULL);
 	} else {
 		struct qib_qp *q, **qpp;

@@ -303,7 +303,7 @@ unsigned qib_free_all_qps(struct qib_devdata *dd)
 	spin_lock_irqsave(&dev->qpt_lock, flags);
 	for (n = 0; n < dev->qp_table_size; n++) {
 		qp = dev->qp_table[n];
-		rcu_assign_pointer(dev->qp_table[n], NULL);
+		RCU_INIT_POINTER(dev->qp_table[n], NULL);

 		for (; qp; qp = qp->next)
 			qp_inuse++;

-- 
1.7.9.5

Re: [PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

From: David Miller <davem@davemloft.net>
Date: 2014-03-19 20:30:13

Many of your patches, such as this one, all have the same exact
subject line.

This makes it impossible to scan the subject lines and have some
idea what area a commit makes changes.

I would really suggest that you use a subject prefix that references
the driver or subsystem, so for this one:

Subject: [PATCH N/M] infiniband: Use rcu_assign_pointer(x, NULL instead) of RCU_INIT_POINTER(x, NULL)

and likewise for all of your other patches.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help