[PATCH] xen-netback: Proper printf format for ptrdiff_t is 't'.

Subsystems: networking drivers, the rest, xen network backend driver

STALE4561d

2 messages, 2 authors, 2014-03-26 · open the first message on its own page

[PATCH] xen-netback: Proper printf format for ptrdiff_t is 't'.

From: David Miller <davem@davemloft.net>
Date: 2014-03-25 23:03:31

This fixes:

drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’:
drivers/net/xen-netback/netback.c:1573:8: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long int’ [-Wformat=]

Signed-off-by: David S. Miller <davem@davemloft.net>
---

Committed to net-next, this has been bugging me for weeks.

 drivers/net/xen-netback/netback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 1f595e5..1e46287 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1569,7 +1569,7 @@ static inline void xenvif_tx_dealloc_action(struct xenvif *vif)
 					vif->pages_to_unmap,
 					gop - vif->tx_unmap_ops);
 		if (ret) {
-			netdev_err(vif->dev, "Unmap fail: nr_ops %x ret %d\n",
+			netdev_err(vif->dev, "Unmap fail: nr_ops %tx ret %d\n",
 				   gop - vif->tx_unmap_ops, ret);
 			for (i = 0; i < gop - vif->tx_unmap_ops; ++i) {
 				if (gop[i].status != GNTST_okay)
-- 
1.8.5.3

Re: [PATCH] xen-netback: Proper printf format for ptrdiff_t is 't'.

From: Ian Campbell <hidden>
Date: 2014-03-26 09:51:00

On Tue, 2014-03-25 at 19:03 -0400, David Miller wrote:
This fixes:

drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’:
drivers/net/xen-netback/netback.c:1573:8: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long int’ [-Wformat=]

Signed-off-by: David S. Miller <davem@davemloft.net>
---

Committed to net-next, this has been bugging me for weeks.
Oops sorry. Ack to the patch FWIW.

Ian.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help