[PATCH][net-next] ipv4: remove ipv4_ifdown_dst from route.c

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE4546d

2 messages, 2 authors, 2014-03-24 · open the first message on its own page

[PATCH][net-next] ipv4: remove ipv4_ifdown_dst from route.c

From: <hidden>
Date: 2014-03-24 03:03:11

From: Li RongQing <redacted> 

ipv4_ifdown_dst does nothing after IPv4 route caches removal,
so we can remove it.

Signed-off-by: Li RongQing <redacted>
---
 net/ipv4/route.c |    6 ------
 1 file changed, 6 deletions(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 11e4384..57527ee 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -139,11 +139,6 @@ static void		 ip_do_redirect(struct dst_entry *dst, struct sock *sk,
 					struct sk_buff *skb);
 static void		ipv4_dst_destroy(struct dst_entry *dst);
 
-static void ipv4_dst_ifdown(struct dst_entry *dst, struct net_device *dev,
-			    int how)
-{
-}
-
 static u32 *ipv4_cow_metrics(struct dst_entry *dst, unsigned long old)
 {
 	WARN_ON(1);
@@ -162,7 +157,6 @@ static struct dst_ops ipv4_dst_ops = {
 	.mtu =			ipv4_mtu,
 	.cow_metrics =		ipv4_cow_metrics,
 	.destroy =		ipv4_dst_destroy,
-	.ifdown =		ipv4_dst_ifdown,
 	.negative_advice =	ipv4_negative_advice,
 	.link_failure =		ipv4_link_failure,
 	.update_pmtu =		ip_rt_update_pmtu,
-- 
1.7.10.4

Re: [PATCH][net-next] ipv4: remove ipv4_ifdown_dst from route.c

From: David Miller <davem@davemloft.net>
Date: 2014-03-24 04:21:08

From: roy.qing.li@gmail.com
Date: Mon, 24 Mar 2014 11:03:10 +0800
From: Li RongQing <redacted> 

ipv4_ifdown_dst does nothing after IPv4 route caches removal,
so we can remove it.

Signed-off-by: Li RongQing <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help