[PATCH net-next] neigh: directly goto out after setting nud_state to NUD_FAILED

Subsystems: networking [general], the rest

STALE4543d

2 messages, 2 authors, 2014-02-27 · open the first message on its own page

[PATCH net-next] neigh: directly goto out after setting nud_state to NUD_FAILED

From: Duan Jiong <hidden>
Date: 2014-02-27 09:04:25

Because those following if conditions will not be matched.

Signed-off-by: Duan Jiong <redacted>
---
 net/core/neighbour.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index b9e9e0d..026bfd1 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -945,6 +945,7 @@ static void neigh_timer_handler(unsigned long arg)
 		neigh->nud_state = NUD_FAILED;
 		notify = 1;
 		neigh_invalidate(neigh);
+		goto out;
 	}
 
 	if (neigh->nud_state & NUD_IN_TIMER) {
-- 
1.8.3.1

Re: [PATCH net-next] neigh: directly goto out after setting nud_state to NUD_FAILED

From: David Miller <davem@davemloft.net>
Date: 2014-02-27 21:41:07

From: Duan Jiong <redacted>
Date: Thu, 27 Feb 2014 17:03:03 +0800
Because those following if conditions will not be matched.

Signed-off-by: Duan Jiong <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help