[PATCH v2 net-next] ipv6: log src and dst along with "udp checksum is 0"

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE4550d

2 messages, 2 authors, 2014-02-26 · open the first message on its own page

[PATCH v2 net-next] ipv6: log src and dst along with "udp checksum is 0"

From: Bjørn Mork <bjorn@mork.no>
Date: 2014-02-25 20:11:19

These info messages are rather pointless without any means to identify
the source of the bogus packets.  Logging the src and dst addresses and
ports may help a bit.

Cc: Joe Perches <joe@perches.com>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
v2: log port numbers too.  Suggested by Joe Perches

build tested only


 net/ipv6/ip6_checksum.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c
index 72d198b8e4d2..ee7a97f510cb 100644
--- a/net/ipv6/ip6_checksum.c
+++ b/net/ipv6/ip6_checksum.c
@@ -79,7 +79,9 @@ int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto)
 		/* RFC 2460 section 8.1 says that we SHOULD log
 		   this error. Well, it is reasonable.
 		 */
-		LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0\n");
+		LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0 for [%pI6c]:%u->[%pI6c]:%u\n",
+			       &ipv6_hdr(skb)->saddr, ntohs(uh->source),
+			       &ipv6_hdr(skb)->daddr, ntohs(uh->dest));
 		return 1;
 	}
 	if (skb->ip_summed == CHECKSUM_COMPLETE &&
-- 
1.9.0

Re: [PATCH v2 net-next] ipv6: log src and dst along with "udp checksum is 0"

From: David Miller <davem@davemloft.net>
Date: 2014-02-26 20:47:14

From: Bjørn Mork <bjorn@mork.no>
Date: Tue, 25 Feb 2014 21:11:02 +0100
These info messages are rather pointless without any means to identify
the source of the bogus packets.  Logging the src and dst addresses and
ports may help a bit.

Cc: Joe Perches <joe@perches.com>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
v2: log port numbers too.  Suggested by Joe Perches
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help