# RE: \[PATCH RFC 1/6\] net: rfkill: gpio: fix gpio name buffer size off by 1

- From: David Laight \<hidden\>
- Date: 2014-01-17 09:49:25 
- List: netdev
- Page: https://ratatoskr.run/netdev/2014/01/4183557
- Thread: https://ratatoskr.run/netdev/2014/01/4183479/t.md

```text
From: Chen-Yu Tsai
> snprintf should be passed the complete size of the buffer, including
> the space for '\0'. The previous code resulted in the *_reset and
> *_shutdown strings being truncated.
...
> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
...
> -	snprintf(rfkill->reset_name, len + 6 , "%s_reset", rfkill->name);
> -	snprintf(rfkill->shutdown_name, len + 9, "%s_shutdown", rfkill->name);
> +	snprintf(rfkill->reset_name, len + 7 , "%s_reset", rfkill->name);
> +	snprintf(rfkill->shutdown_name, len + 10, "%s_shutdown", rfkill->name);

I can't find the context for the above, but they look very dubious.
I'd expect: snprintf(foo, sizeof foo, ...).
If you are trying to truncate rfkill->name you need to use %.*s.

	David
```
