[patch net-next] ipv4: loopback device: ignore value changes after device is upped

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE4591d

2 messages, 2 authors, 2014-01-07 · open the first message on its own page

[patch net-next] ipv4: loopback device: ignore value changes after device is upped

From: Jiri Pirko <jiri@resnulli.us>
Date: 2014-01-07 14:55:50

When lo is brought up, new ifa is created. Then, devconf and neigh values
bitfield should be set so later changes of default values would not
affect lo values.

Note that the same behaviour is in ipv6. Also note that this is likely
not an issue in many distros (for example Fedora 19) because userspace
sets address to lo manually before bringing it up.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
 net/ipv4/devinet.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 0feebd5..9809f7b 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1385,6 +1385,8 @@ static int inetdev_event(struct notifier_block *this, unsigned long event,
 				memcpy(ifa->ifa_label, dev->name, IFNAMSIZ);
 				set_ifa_lifetime(ifa, INFINITY_LIFE_TIME,
 						 INFINITY_LIFE_TIME);
+				ipv4_devconf_setall(in_dev);
+				neigh_parms_data_state_setall(in_dev->arp_parms);
 				inet_insert_ifa(ifa);
 			}
 		}
-- 
1.8.3.1

Re: [patch net-next] ipv4: loopback device: ignore value changes after device is upped

From: David Miller <davem@davemloft.net>
Date: 2014-01-07 20:55:52

From: Jiri Pirko <jiri@resnulli.us>
Date: Tue,  7 Jan 2014 15:55:45 +0100
When lo is brought up, new ifa is created. Then, devconf and neigh values
bitfield should be set so later changes of default values would not
affect lo values.

Note that the same behaviour is in ipv6. Also note that this is likely
not an issue in many distros (for example Fedora 19) because userspace
sets address to lo manually before bringing it up.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Looks good, applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help