[PATCH net-next 06/20] net: igbvf: slight optimization of addr compare

Subsystems: intel ethernet drivers, networking drivers, the rest

STALE4605d

2 messages, 2 authors, 2013-12-27 · open the first message on its own page

[PATCH net-next 06/20] net: igbvf: slight optimization of addr compare

From: Ding Tianhong <hidden>
Date: 2013-12-27 06:49:41

Use possibly more efficient ether_addr_equal
to instead of memcmp.

Cc: Jeff Kirsher <redacted>
Cc: Jesse Brandeburg <redacted>
Cc: Carolyn Wyborny <redacted>
Cc: Don Skidmore <redacted>
Signed-off-by: Ding Tianhong <redacted>
---
 drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index 04bf22e..675435f 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -1745,7 +1745,7 @@ static int igbvf_set_mac(struct net_device *netdev, void *p)
 
 	hw->mac.ops.rar_set(hw, hw->mac.addr, 0);
 
-	if (memcmp(addr->sa_data, hw->mac.addr, 6))
+	if (!ether_addr_equal(addr->sa_data, hw->mac.addr))
 		return -EADDRNOTAVAIL;
 
 	memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
-- 
1.8.0

Re: [PATCH net-next 06/20] net: igbvf: slight optimization of addr compare

From: Jeff Kirsher <hidden>
Date: 2013-12-27 09:48:53

On Fri, 2013-12-27 at 14:48 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.

Cc: Jeff Kirsher <redacted>
Cc: Jesse Brandeburg <redacted>
Cc: Carolyn Wyborny <redacted>
Cc: Don Skidmore <redacted>
Signed-off-by: Ding Tianhong <redacted>
---
 drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks Ding, I have added this patch to my queue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help