[PATCH 06/21] zd1211rw: slight optimization of addr compare
From: Ding Tianhong <hidden>
Date: 2013-12-23 05:11:22
Also in:
linux-wireless, lkml
Subsystem:
networking drivers (wireless), the rest · Maintainers:
Johannes Berg, Linus Torvalds
Use the recently added and possibly more efficient ether_addr_equal_unaligned to instead of memcmp. Cc: Daniel Drake <redacted> Cc: Ulrich Kunitz <redacted> Cc: "John W. Linville" <redacted> Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Tan Xiaojun <redacted> Signed-off-by: Ding Tianhong <redacted> --- drivers/net/wireless/zd1211rw/zd_mac.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c
index eff79a3..57badfb 100644
--- a/drivers/net/wireless/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/zd1211rw/zd_mac.c@@ -532,9 +532,9 @@ void zd_mac_tx_failed(struct urb *urb) tx_hdr = (struct ieee80211_hdr *)skb->data; /* we skip all frames not matching the reported destination */ - if (unlikely(memcmp(tx_hdr->addr1, tx_status->mac, ETH_ALEN))) { + if (unlikely(!ether_addr_equal_unaligned(tx_hdr->addr1, + tx_status->mac))) continue; - } /* we skip all frames not matching the reported final rate */
@@ -997,7 +997,8 @@ static int filter_ack(struct ieee80211_hw *hw, struct ieee80211_hdr *rx_hdr, continue; tx_hdr = (struct ieee80211_hdr *)skb->data; - if (likely(!memcmp(tx_hdr->addr2, rx_hdr->addr1, ETH_ALEN))) + if (likely(ether_addr_equal_unaligned(tx_hdr->addr2, + rx_hdr->addr1))) { found = 1; break;
--
1.8.0