Thread (2 messages) 2 messages, 2 authors, 2013-11-29

Re: [PATCH v2 04/17] net: bnx2x calls skb_set_rxhash

From: David Miller <davem@davemloft.net>
Date: 2013-11-29 20:43:13

From: Tom Herbert <redacted>
Date: Tue, 26 Nov 2013 09:22:54 -0800 (PST)
-		skb->rxhash = tpa_info->rxhash;
-		skb->l4_rxhash = tpa_info->l4_rxhash;
+		skb_set_rxhash(skb, tpa_info->rxhash,
+		    tpa_info->l4_rxhash ? RXHASH_TYPE_L4 : RXHASH_TYPE_L3);
 ...
-		skb->rxhash = bnx2x_get_rxhash(bp, cqe_fp, &l4_rxhash);
-		skb->l4_rxhash = l4_rxhash;
+		rxhash = bnx2x_get_rxhash(bp, cqe_fp, &l4_rxhash);
+		skb_set_rxhash(skb, rxhash,
+			       l4_rxhash ? RXHASH_TYPE_L4 : RXHASH_TYPE_L3);
Inconsistent indentation, the second one is correct the first one is
not.

Please audit this in your entire patch set, there are few other
instances.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help