David Miller [mailto:davem@davemloft.net] 

Sent: Wednesday, October 30, 2013 5:50 AM
To: Hayeswang
Cc: netdev@vger.kernel.org; nic_swsd; 
linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH net 2/3] r8152: modify the tx flow

From: Hayes Wang <redacted>
Date: Tue, 29 Oct 2013 15:56:16 +0800

quoted

Support stopping and waking tx queue. The maximum tx queue length
is 60.

What is so special about the number 60?  It seems arbitrary, and if
it isn't arbitrary you haven't described why this value was choosen.

The value is arbitrary. I think it is better to stop tx when
queuing many packets, otherwise all the available memory may
be used for tx skb. The queue length could be any value or
unlimited if the memory is enough. Should I remove it?

I've asked you politely last time around to significantly improve
the quality of your commit messages, and you haven't done this at
all.

I thought you indicated the last patch only and the others are clear enough.
I would improve them.

I'm not applying any of these patches until your commit messages
properly describe your changes completely.