[PATCH] qlcnic: add missing destroy_workqueue() on error path in qlcnic_probe()

Subsystems: networking drivers, qlogic qlcnic (1/10)gb ethernet driver, the rest

STALE4686d

2 messages, 2 authors, 2013-10-08 · open the first message on its own page

[PATCH] qlcnic: add missing destroy_workqueue() on error path in qlcnic_probe()

From: Wei Yongjun <hidden>
Date: 2013-10-08 03:32:19

From: Wei Yongjun <redacted>

Add the missing destroy_workqueue() before return from
qlcnic_probe() in the error handling case.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 21d00a0..f07f2b0 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -2257,7 +2257,7 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	err = qlcnic_alloc_adapter_resources(adapter);
 	if (err)
-		goto err_out_free_netdev;
+		goto err_out_free_wq;
 
 	adapter->dev_rst_time = jiffies;
 	adapter->ahw->revision_id = pdev->revision;
@@ -2396,6 +2396,9 @@ err_out_disable_msi:
 err_out_free_hw:
 	qlcnic_free_adapter_resources(adapter);
 
+err_out_free_wq:
+	destroy_workqueue(adapter->qlcnic_wq);
+
 err_out_free_netdev:
 	free_netdev(netdev);
 

Re: [PATCH] qlcnic: add missing destroy_workqueue() on error path in qlcnic_probe()

From: David Miller <davem@davemloft.net>
Date: 2013-10-08 20:53:34

From: Wei Yongjun <redacted>
Date: Tue, 8 Oct 2013 11:32:17 +0800
From: Wei Yongjun <redacted>

Add the missing destroy_workqueue() before return from
qlcnic_probe() in the error handling case.

Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help