[PATCH 4/8] net: fs_enet: use platform_{get,set}_drvdata()

Subsystems: freescale soc fs_enet driver, networking drivers, the rest

STALE4784d

3 messages, 2 authors, 2013-08-14 · open the first message on its own page

[PATCH 4/8] net: fs_enet: use platform_{get,set}_drvdata()

From: Libo Chen <hidden>
Date: 2013-08-12 13:25:18

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Signed-off-by: Libo Chen <redacted>
---
 .../net/ethernet/freescale/fs_enet/fs_enet-main.c  |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index 8de53a1..7e3de10 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev)

 	fep->ops->free_bd(ndev);
 	fep->ops->cleanup_data(ndev);
-	dev_set_drvdata(fep->dev, NULL);
 	of_node_put(fep->fpi->phy_node);
 	free_netdev(ndev);
 	return 0;
-- 
1.7.1

Re: [PATCH 4/8] net: fs_enet: use platform_{get,set}_drvdata()

From: Sergei Shtylyov <hidden>
Date: 2013-08-12 18:16:07

On 08/12/2013 05:24 PM, Libo Chen wrote:
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: Libo Chen <redacted>
---
  .../net/ethernet/freescale/fs_enet/fs_enet-main.c  |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
quoted hunk
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index 8de53a1..7e3de10 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev)

  	fep->ops->free_bd(ndev);
  	fep->ops->cleanup_data(ndev);
-	dev_set_drvdata(fep->dev, NULL);
  	of_node_put(fep->fpi->phy_node);
  	free_netdev(ndev);
  	return 0;
    Changelog simply doesn't match the patch.

WBR, Sergei

[PATCH RESEND 4/8] net: fs_enet: remove unnecessary dev_set_drvdata()

From: Libo Chen <hidden>
Date: 2013-08-14 03:40:08

unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.

Signed-off-by: Libo Chen <redacted>
---
 drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c  |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index 8de53a1..7e3de10 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev)

 	fep->ops->free_bd(ndev);
 	fep->ops->cleanup_data(ndev);
-	dev_set_drvdata(fep->dev, NULL);
 	of_node_put(fep->fpi->phy_node);
 	free_netdev(ndev);
 	return 0;
-- 
1.7.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help