No more checkpatch "fixes" from newer developers.

From: David Miller <davem@davemloft.net>
Date: 2013-08-21 06:44:22

I've really had it with "checkpatch" fixes that break things.

Case in point, the recent ipv6 checkpatch fixes did this:

 	/* first try to inherit the link-local address from the link device */
-	if (idev->dev->iflink &&
-	    (link_dev = __dev_get_by_index(net, idev->dev->iflink))) {
-		if (!ipv6_inherit_linklocal(idev, link_dev))
+	if (idev->dev->iflink)
+		link_dev = __dev_get_by_index(net, idev->dev->iflink);
+		if (link_dev && !ipv6_inherit_linklocal(idev, link_dev))
 			return;
-	}
+

Are you kidding me?  The openning and closing curly braces that create
the basic block were erroneously removed.  Now the value of link_dev
is not defined.

I'm reverting this, and don't bother submitting these kinds of changes
any more, I'm going to ignore them.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help