Re: [PATCH 6/7] net: add the AF_FLEXRAY protocol

On 13.08.2013 11:08, Benedikt Spranger wrote:

FlexRay is a networking technology used in automotive fields as
successor of the Controller Area Network (CAN). It provides the
core functionality and a RAW protocol driver.

Signed-off-by: Benedikt Spranger <redacted>
---
Documentation/networking/00-INDEX             |   2 +
Documentation/networking/flexray.txt          |  24 ++
include/linux/flexray.h                       | 168 ++++++++

Hello Benedikt,

thanks for bringing flexray to linux.

Some general remarks/questions:
- how can errors (crc, boundary, tx on not empty slot) be transported by the frame like in a CAN frame (/include/uapi/linux/can/error.h):
	-> canid_t can_id;  /* 32 bit CAN_ID + EFF/RTR/ERR flags */ ? 
	...there is no more space in the id field in your frame definition.
- what about special bus content like wakeup pattern (WUP), collision avoidance symbol (CAS) and media test symbols (MTS). These are interesting for logging use cases.
- do we need the crc fields? What happens if the cr check fails (-> error flag)? Do we need this information then?
- do we need the reserved bit? (there is none in CAN frame definition)

Best regards,
Sven