[PATCH] net: fix build warning in trans_rdma.c

Subsystems: 9p file system, the rest

STALE4789d

2 messages, 2 authors, 2013-07-30 · open the first message on its own page

[PATCH] net: fix build warning in trans_rdma.c

From: Xishi Qiu <hidden>
Date: 2013-07-30 09:18:18

When building v3.11-rc3, I get the following warning:
...
net/9p/trans_rdma.c:594: warning: ‘rdma_cancelled’ defined but not used
...
As the function is not be used, so remove it.

Signed-off-by: Xishi Qiu <redacted>
---
 net/9p/trans_rdma.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index 928f2bb..8f68df5 100644
--- a/net/9p/trans_rdma.c
+++ b/net/9p/trans_rdma.c
@@ -588,17 +588,6 @@ static int rdma_cancel(struct p9_client *client, struct p9_req_t *req)
 	return 1;
 }
 
-/* A request has been fully flushed without a reply.
- * That means we have posted one buffer in excess.
- */
-static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)
-{
-	struct p9_trans_rdma *rdma = client->trans;
-
-	atomic_inc(&rdma->excess_rc);
-	return 0;
-}
-
 /**
  * trans_create_rdma - Transport method for creating atransport instance
  * @client: client instance
-- 
1.7.1

Re: [PATCH] net: fix build warning in trans_rdma.c

From: Daniel Baluta <hidden>
Date: 2013-07-30 09:27:48

On Tue, Jul 30, 2013 at 12:15 PM, Xishi Qiu [off-list ref] wrote:
quoted hunk
When building v3.11-rc3, I get the following warning:
...
net/9p/trans_rdma.c:594: warning: ‘rdma_cancelled’ defined but not used
...
As the function is not be used, so remove it.

Signed-off-by: Xishi Qiu <redacted>
---
 net/9p/trans_rdma.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index 928f2bb..8f68df5 100644
--- a/net/9p/trans_rdma.c
+++ b/net/9p/trans_rdma.c
@@ -588,17 +588,6 @@ static int rdma_cancel(struct p9_client *client, struct p9_req_t *req)
        return 1;
 }

-/* A request has been fully flushed without a reply.
- * That means we have posted one buffer in excess.
- */
-static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)
-{
-       struct p9_trans_rdma *rdma = client->trans;
-
-       atomic_inc(&rdma->excess_rc);
-       return 0;
-}
-
 /**
  * trans_create_rdma - Transport method for creating atransport instance
  * @client: client instance
Hi,

This is wrong.

Please check http://comments.gmane.org/gmane.linux.network/276261.

thanks,
Daniel.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help