[PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit
Subsystems:
atmel macb ethernet driver, networking drivers, the rest
STALE4814d
3 messages,
3 authors,
2013-07-09 · open the first message on its own page
Signed-off-by: Jongsung Kim <redacted>
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index c89aa41..b4e0dc8 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1070,7 +1070,7 @@ static void macb_configure_dma(struct macb *bp)
static void macb_configure_caps(struct macb *bp)
{
if (macb_is_gem(bp)) {
- if (GEM_BF(IRQCOR, gem_readl(bp, DCFG1)) == 0)
+ if (GEM_BFEXT(IRQCOR, gem_readl(bp, DCFG1)) == 0)
bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
}
}--
1.7.1
On 09/07/2013 10:36, Jongsung Kim :
Signed-off-by: Jongsung Kim <redacted>
Acked-by: Nicolas Ferre <redacted>
Cc: stable <redacted> # 3.10+
Thanks for having spotted that.
Best regards,
quoted hunk
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index c89aa41..b4e0dc8 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1070,7 +1070,7 @@ static void macb_configure_dma(struct macb *bp)
static void macb_configure_caps(struct macb *bp)
{
if (macb_is_gem(bp)) {
- if (GEM_BF(IRQCOR, gem_readl(bp, DCFG1)) == 0)
+ if (GEM_BFEXT(IRQCOR, gem_readl(bp, DCFG1)) == 0)
bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
}
}
--
Nicolas Ferre
From: Nicolas Ferre <redacted>
Date: Tue, 9 Jul 2013 18:02:23 +0200
On 09/07/2013 10:36, Jongsung Kim :
quoted
Signed-off-by: Jongsung Kim <redacted>
Acked-by: Nicolas Ferre <redacted>
Cc: stable <redacted> # 3.10+
Applied and queued up for -stable, thanks.