[RESEND PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE4808d REVIEWED: 2 (0M)

2 review trailers.

2 messages, 2 authors, 2013-07-24 · open the first message on its own page

[RESEND PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization

From: Fan Du <hidden>
Date: 2013-07-22 06:20:19

Seting rt->rt6i_nsiblings to zero is rebundant, because above memset
zeroed the rest of rt excluding the first dst memember.

Signed-off-by: Fan Du <redacted>
Acked-by: Nicolas Dichtel <redacted>
Acked-by: Hannes Frederic Sowa <redacted>
Cc: Hideaki YOSHIFUJI <redacted>
Cc: James Morris <jmorris@namei.org>
---
 net/ipv6/route.c |    1 -
 1 file changed, 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 45ca9af..ce96163 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -285,7 +285,6 @@ static inline struct rt6_info *ip6_dst_alloc(struct net *net,
 		rt6_init_peer(rt, table ? &table->tb6_peers : net->ipv6.peers);
 		rt->rt6i_genid = rt_genid_ipv6(net);
 		INIT_LIST_HEAD(&rt->rt6i_siblings);
-		rt->rt6i_nsiblings = 0;
 	}
 	return rt;
 }
-- 
1.7.9.5

Re: [RESEND PATCH net-next] net ipv6: Remove rebundant rt6i_nsiblings initialization

From: David Miller <davem@davemloft.net>
Date: 2013-07-24 21:26:26

From: Fan Du <redacted>
Date: Mon, 22 Jul 2013 14:20:12 +0800
Seting rt->rt6i_nsiblings to zero is rebundant, because above memset
zeroed the rest of rt excluding the first dst memember.

Signed-off-by: Fan Du <redacted>
Acked-by: Nicolas Dichtel <redacted>
Acked-by: Hannes Frederic Sowa <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help