[PATCH 08/12] net/ethernet: MACB should depend on HAS_DMA

Subsystems: atmel macb ethernet driver, networking drivers, the rest

STALE4898d

3 messages, 3 authors, 2013-05-11 · open the first message on its own page

[PATCH 08/12] net/ethernet: MACB should depend on HAS_DMA

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2013-05-09 21:07:52

If NO_DMA=y:

drivers/built-in.o: In function `macb_free_consistent':
drivers/net/ethernet/cadence/macb.c:878: undefined reference to `dma_free_coherent'
drivers/net/ethernet/cadence/macb.c:883: undefined reference to `dma_free_coherent'
drivers/net/ethernet/cadence/macb.c:888: undefined reference to `dma_free_coherent'
drivers/built-in.o: In function `macb_alloc_consistent':
drivers/net/ethernet/cadence/macb.c:905: undefined reference to `dma_alloc_coherent'
drivers/built-in.o: In function `macb_tx_interrupt':
drivers/net/ethernet/cadence/macb.c:515: undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `macb_tx_error_task':
drivers/net/ethernet/cadence/macb.c:457: undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `macb_start_xmit':
drivers/net/ethernet/cadence/macb.c:838: undefined reference to `dma_map_single'

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Nicolas Ferre <redacted>
Cc: David S. Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
---
 drivers/net/ethernet/cadence/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
index 0d9d6e6..768285e 100644
--- a/drivers/net/ethernet/cadence/Kconfig
+++ b/drivers/net/ethernet/cadence/Kconfig
@@ -31,6 +31,7 @@ config ARM_AT91_ETHER
 
 config MACB
 	tristate "Cadence MACB/GEM support"
+	depends on HAS_DMA
 	select PHYLIB
 	---help---
 	  The Cadence MACB ethernet interface is found on many Atmel AT32 and
-- 
1.7.0.4

Re: [PATCH 08/12] net/ethernet: MACB should depend on HAS_DMA

From: Nicolas Ferre <hidden>
Date: 2013-05-10 08:22:39

On 09/05/2013 23:04, Geert Uytterhoeven :
If NO_DMA=y:

drivers/built-in.o: In function `macb_free_consistent':
drivers/net/ethernet/cadence/macb.c:878: undefined reference to `dma_free_coherent'
drivers/net/ethernet/cadence/macb.c:883: undefined reference to `dma_free_coherent'
drivers/net/ethernet/cadence/macb.c:888: undefined reference to `dma_free_coherent'
drivers/built-in.o: In function `macb_alloc_consistent':
drivers/net/ethernet/cadence/macb.c:905: undefined reference to `dma_alloc_coherent'
drivers/built-in.o: In function `macb_tx_interrupt':
drivers/net/ethernet/cadence/macb.c:515: undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `macb_tx_error_task':
drivers/net/ethernet/cadence/macb.c:457: undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `macb_start_xmit':
drivers/net/ethernet/cadence/macb.c:838: undefined reference to `dma_map_single'

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Nicolas Ferre <redacted>
Acked-by: Nicolas Ferre <redacted>
quoted hunk
Cc: David S. Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
---
  drivers/net/ethernet/cadence/Kconfig |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
index 0d9d6e6..768285e 100644
--- a/drivers/net/ethernet/cadence/Kconfig
+++ b/drivers/net/ethernet/cadence/Kconfig
@@ -31,6 +31,7 @@ config ARM_AT91_ETHER

  config MACB
  	tristate "Cadence MACB/GEM support"
+	depends on HAS_DMA
  	select PHYLIB
  	---help---
  	  The Cadence MACB ethernet interface is found on many Atmel AT32 and

-- 
Nicolas Ferre

Re: [PATCH 08/12] net/ethernet: MACB should depend on HAS_DMA

From: David Miller <davem@davemloft.net>
Date: 2013-05-11 23:29:32

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu,  9 May 2013 23:04:50 +0200
If NO_DMA=y:
 ...
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help