[PATCH] bonding: change igmp_retrans type from s8 to u8

Subsystems: bonding driver, networking drivers, the rest

STALE4879d

2 messages, 1 author, 2013-05-30 · open the first message on its own page

[PATCH] bonding: change igmp_retrans type from s8 to u8

From: <hidden>
Date: 2013-05-29 15:05:52

From: Nikolay Aleksandrov <redacted>

According to the bonding documentation and to the error messages the
resend_igmp should be between 0 and 255, but since the type of the
variable that counts is wrong, this is not the case.
We have igmp_retrans = resend_igmp when the work is started.

Signed-off-by: Nikolay Aleksandrov <redacted>
---
 drivers/net/bonding/bonding.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index 2baec24..f989e15 100644
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -225,7 +225,7 @@ struct bonding {
 	rwlock_t curr_slave_lock;
 	u8	 send_peer_notif;
 	s8	 setup_by_slave;
-	s8       igmp_retrans;
+	u8       igmp_retrans;
 #ifdef CONFIG_PROC_FS
 	struct   proc_dir_entry *proc_entry;
 	char     proc_file_name[IFNAMSIZ];
-- 
1.8.1.4

Re: [PATCH] bonding: change igmp_retrans type from s8 to u8

From: Nikolay Aleksandrov <hidden>
Date: 2013-05-30 08:58:01

On 29/05/13 17:02, nikolay@redhat.com wrote:
From: Nikolay Aleksandrov <redacted>

According to the bonding documentation and to the error messages the
resend_igmp should be between 0 and 255, but since the type of the
variable that counts is wrong, this is not the case.
We have igmp_retrans = resend_igmp when the work is started.

Signed-off-by: Nikolay Aleksandrov <redacted>
---
Self-NACK, there's another related bug and this is not a full fix.
Dave please don't apply this patch, I'll resend a proper fix.

Nik
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help