Re: [PATCH 05/36] net: ethernet: 8390: remove unnecessary platform_set_drvdata()
From: Jingoo Han <hidden>
Date: 2013-05-28 04:53:47
On Tuesday, May 07, 2013 1:19 PM, Jingoo Han wrote:
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <redacted>
Hi David, I will squash everything down into one patch with the ACKs, and send it again. Best regards, Jingoo Han
quoted hunk
--- drivers/net/ethernet/8390/ne.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)diff --git a/drivers/net/ethernet/8390/ne.c b/drivers/net/ethernet/8390/ne.c index 47618e5..b2e8405 100644 --- a/drivers/net/ethernet/8390/ne.c +++ b/drivers/net/ethernet/8390/ne.c@@ -849,7 +849,6 @@ static int ne_drv_remove(struct platform_device *pdev) free_irq(dev->irq, dev); release_region(dev->base_addr, NE_IO_EXTENT); free_netdev(dev); - platform_set_drvdata(pdev, NULL); } return 0; } --1.7.2.5