[PATCH 19/36] net: ethernet: netx: remove unnecessary platform_set_drvdata()
DORMANTno replies
From: Jingoo Han <hidden>
Date: 2013-05-07 04:41:34
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <redacted> --- drivers/net/ethernet/netx-eth.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/netx-eth.c b/drivers/net/ethernet/netx-eth.c
index cb9e638..987889c 100644
--- a/drivers/net/ethernet/netx-eth.c
+++ b/drivers/net/ethernet/netx-eth.c@@ -422,7 +422,6 @@ exit_free_pfifo: exit_free_xc: free_xc(priv->xc); exit_free_netdev: - platform_set_drvdata(pdev, NULL); free_netdev(ndev); exit: return ret;
@@ -433,8 +432,6 @@ static int netx_eth_drv_remove(struct platform_device *pdev) struct net_device *ndev = dev_get_drvdata(&pdev->dev); struct netx_eth_priv *priv = netdev_priv(ndev); - platform_set_drvdata(pdev, NULL); - unregister_netdev(ndev); xc_stop(priv->xc); free_xc(priv->xc);
--
1.7.2.5