[PATCH RFT] 3c59x: fix freeing nonexistent resource on driver unload

When unloading the driver that drives an EISA board, a message similar to the
following one is displayed:

Trying to free nonexistent resource <0000000000013000-000000000001301f>

Then an user is unable to reload the driver because the resource it requested in
the previous load hasn't been freed. This happens most probably due to a typo in
vortex_eisa_remove() which calls release_region() with 'dev->base_addr'  instead
of 'edev->base_addr'...

Reported-by: Matthew Whitehead <redacted>
Signed-off-by: Sergei Shtylyov <redacted>

---
The patch is against David Miller's 'net-next.git' repo.
Matthew, please test it and report on the list.

 drivers/net/ethernet/3com/3c59x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: net-next/drivers/net/ethernet/3com/3c59x.c
===================================================================

--- net-next.orig/drivers/net/ethernet/3com/3c59x.c
+++ net-next/drivers/net/ethernet/3com/3c59x.c

@@ -951,7 +951,7 @@ static int vortex_eisa_remove(struct dev
 
 	unregister_netdev(dev);
 	iowrite16(TotalReset|0x14, ioaddr + EL3_CMD);
-	release_region(dev->base_addr, VORTEX_TOTAL_SIZE);
+	release_region(edev->base_addr, VORTEX_TOTAL_SIZE);
 
 	free_netdev(dev);
 	return 0;

Hello.

On 05/03/2013 01:10 AM, Sergei Shtylyov wrote:

When unloading the driver that drives an EISA board, a message similar to the
following one is displayed:

Trying to free nonexistent resource <0000000000013000-000000000001301f>

Then an user is unable to reload the driver because the resource it requested in
the previous load hasn't been freed. This happens most probably due to a typo in
vortex_eisa_remove() which calls release_region() with 'dev->base_addr'  instead
of 'edev->base_addr'...

Reported-by: Matthew Whitehead <redacted>

   Should I repost this now with [RFT] removed and this line changed to:

Reported-and-tested-by: Matthew Whitehead <redacted>


or could you do it when/if applying, David?

Signed-off-by: Sergei Shtylyov <redacted>

WBR, Sergei

From: Sergei Shtylyov <redacted>
Date: Fri, 3 May 2013 01:10:22 +0400

When unloading the driver that drives an EISA board, a message similar to the
following one is displayed:

Trying to free nonexistent resource <0000000000013000-000000000001301f>

Then an user is unable to reload the driver because the resource it requested in
the previous load hasn't been freed. This happens most probably due to a typo in
vortex_eisa_remove() which calls release_region() with 'dev->base_addr'  instead
of 'edev->base_addr'...

Reported-by: Matthew Whitehead <redacted>
Signed-off-by: Sergei Shtylyov <redacted>

Applied, thanks.

On 05/06/2013 08:22 PM, David Miller wrote:

quoted

When unloading the driver that drives an EISA board, a message similar to the
following one is displayed:

Trying to free nonexistent resource <0000000000013000-000000000001301f>

Then an user is unable to reload the driver because the resource it requested in
the previous load hasn't been freed. This happens most probably due to a typo in
vortex_eisa_remove() which calls release_region() with 'dev->base_addr'  instead
of 'edev->base_addr'...

Reported-by: Matthew Whitehead <redacted>
Signed-off-by: Sergei Shtylyov <redacted>

Applied, thanks.

   Will you queue this patch for stable?

WBR, Sergei

From: Sergei Shtylyov <redacted>
Date: Tue, 07 May 2013 00:45:30 +0400

   Will you queue this patch for stable?

Done.

On 05/07/2013 12:50 AM, David Miller wrote:

quoted

    Will you queue this patch for stable?

Done.

   Thank you. It's really ancient error, though for the ancient boards only as well...

WBR, Sergei