[PATCH net-next] net: remove redundant code in dev_hard_start_xmit()

Subsystems: networking [general], the rest

STALE4862d

2 messages, 2 authors, 2013-04-25 · open the first message on its own page

[PATCH net-next] net: remove redundant code in dev_hard_start_xmit()

From: Eric Dumazet <hidden>
Date: 2013-04-23 00:31:36

From: Eric Dumazet <edumazet@google.com>

This reverts commit 068a2de57ddf4f4 (net: release dst entry while
cache-hot for GSO case too)

Before GSO packet segmentation, we already take care of skb->dst if it
can be released.

There is no point adding extra test for every segment in the gso loop.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Krishna Kumar <redacted>
---
 net/core/dev.c |    7 -------
 1 file changed, 7 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 8a3cb2c..6a82eed 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2543,13 +2543,6 @@ gso:
 		skb->next = nskb->next;
 		nskb->next = NULL;
 
-		/*
-		 * If device doesn't need nskb->dst, release it right now while
-		 * its hot in this cpu cache
-		 */
-		if (dev->priv_flags & IFF_XMIT_DST_RELEASE)
-			skb_dst_drop(nskb);
-
 		if (!list_empty(&ptype_all))
 			dev_queue_xmit_nit(nskb, dev);
 

Re: [PATCH net-next] net: remove redundant code in dev_hard_start_xmit()

From: David Miller <davem@davemloft.net>
Date: 2013-04-25 05:39:27

From: Eric Dumazet <redacted>
Date: Mon, 22 Apr 2013 17:31:34 -0700
From: Eric Dumazet <edumazet@google.com>

This reverts commit 068a2de57ddf4f4 (net: release dst entry while
cache-hot for GSO case too)

Before GSO packet segmentation, we already take care of skb->dst if it
can be released.

There is no point adding extra test for every segment in the gso loop.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help