[PATCH] eicon: Fixed checkpatch warning

Subsystems: the rest

STALE4929d

3 messages, 2 authors, 2013-03-10 · open the first message on its own page

[PATCH] eicon: Fixed checkpatch warning

From: Andreea Hodea <hidden>
Date: 2013-03-10 12:35:10

drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol
'DRIVERRELEASE_DIDD' was not declared. Should it be static?

Signed-off-by: Andreea Hodea <redacted>
---
 drivers/isdn/hardware/eicon/diva_didd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/eicon/diva_didd.c b/drivers/isdn/hardware/eicon/diva_didd.c
index fab6ccf..21468be 100644
--- a/drivers/isdn/hardware/eicon/diva_didd.c
+++ b/drivers/isdn/hardware/eicon/diva_didd.c
@@ -29,7 +29,7 @@ static char *main_revision = "$Revision: 1.13.6.4 $";
 static char *DRIVERNAME =
 	"Eicon DIVA - DIDD table (http://www.melware.net)";
 static char *DRIVERLNAME = "divadidd";
-char *DRIVERRELEASE_DIDD = "2.0";
+static char *DRIVERRELEASE_DIDD = "2.0";
 
 MODULE_DESCRIPTION("DIDD table driver for diva drivers");
 MODULE_AUTHOR("Cytronics & Melware, Eicon Networks");
-- 
1.7.10.4

Re: [PATCH] eicon: Fixed checkpatch warning

From: David Miller <davem@davemloft.net>
Date: 2013-03-10 20:56:08

From: Andreea Hodea <redacted>
Date: Sun, 10 Mar 2013 14:34:36 +0200
drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol
'DRIVERRELEASE_DIDD' was not declared. Should it be static?

Signed-off-by: Andreea Hodea <redacted>
Applied, thanks.

Re: [PATCH] eicon: Fixed checkpatch warning

From: David Miller <davem@davemloft.net>
Date: 2013-03-10 22:02:13

From: David Miller <davem@davemloft.net>
Date: Sun, 10 Mar 2013 16:56:13 -0400 (EDT)
From: Andreea Hodea <redacted>
Date: Sun, 10 Mar 2013 14:34:36 +0200
quoted
drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol
'DRIVERRELEASE_DIDD' was not declared. Should it be static?

Signed-off-by: Andreea Hodea <redacted>
Applied, thanks.
I had to revert, did you even try to compile the driver after
this change?

The symbol is refenced by DbgRegister() calls in diddfunc.c, and
a very simple grep would have shown that to you.

Please do not just blindly try to fix checkpatch warnings.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help