be2net failed to initialize regression

Emulex CNA card failed to initialize using 3.8 and the latest upstream kernel,

[   87.479859] be2net 0000:04:00.0: POST timeout; stage=0xc911 
[   87.515978] be2net 0000:04:00.0: Emulex OneConnect initialization failed 
[   87.557130] be2net: probe of 0000:04:00.0 failed with error -1 

lspci output,

04:00.0 Ethernet controller: Emulex Corporation OneConnect 10Gb NIC (rev 02)
04:00.1 Ethernet controller: Emulex Corporation OneConnect 10Gb NIC (rev 02)

04:00.1 Ethernet controller: Emulex Corporation OneConnect 10Gb NIC (rev 02)
        Subsystem: Hewlett-Packard Company NC551i Dual Port FlexFabric 10Gb Adapter

Confirmed no such problem using 3.7 kernel. Reproduced every time and still
bisecting. Just want to give an early head-up to see if anyone saw sometime
obvious.

CAI Qian

-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
On Behalf Of CAI Qian

Emulex CNA card failed to initialize using 3.8 and the latest upstream kernel,

[   87.479859] be2net 0000:04:00.0: POST timeout; stage=0xc911
[   87.515978] be2net 0000:04:00.0: Emulex OneConnect initialization failed
[   87.557130] be2net: probe of 0000:04:00.0 failed with error -1

lspci output,

04:00.0 Ethernet controller: Emulex Corporation OneConnect 10Gb NIC (rev 02)
04:00.1 Ethernet controller: Emulex Corporation OneConnect 10Gb NIC (rev 02)

04:00.1 Ethernet controller: Emulex Corporation OneConnect 10Gb NIC (rev 02)
        Subsystem: Hewlett-Packard Company NC551i Dual Port FlexFabric 10Gb
Adapter

Confirmed no such problem using 3.7 kernel. Reproduced every time and still
bisecting. Just want to give an early head-up to see if anyone saw sometime
obvious.

Could you give me the FW version (ethtool -i) of the adapter (after be2net successfully
probes in a 3.7 kernel.)

If the FW version is as old as 2.x, then the culprit commit that broke compatibility with old FW versions
on some (BE2) chips I is:
commit 1bc8e7e4f36c0c19dd7dea29e7c248b7c6ef3a15
be2net: fix access to SEMAPHORE reg

The fix for this is (still on David's net tree I guess):
commit c5b3ad4c67989c778e4753be4f91dc7193a04d21
be2net: use CSR-BAR SEMAPHORE reg for BE2/BE3

Dave, can these 2 commits be queued for stable too:
commit1: c5b3ad4c67989c778e4753be4f91dc7193a04d21
commit2: 1bc8e7e4f36c0c19dd7dea29e7c248b7c6ef3a15

thanks,
-Sathya

----- Original Message -----

From: "Sathya Perla" <redacted>
To: "CAI Qian" <redacted>, netdev@vger.kernel.org
Cc: "Ivan Vecera" <ivecera@redhat.com>, "LKML" <redacted>
Sent: Friday, March 8, 2013 6:22:24 PM
Subject: RE: be2net failed to initialize regression

quoted

-----Original Message-----
From: netdev-owner@vger.kernel.org
[mailto:netdev-owner@vger.kernel.org]
On Behalf Of CAI Qian

Emulex CNA card failed to initialize using 3.8 and the latest
upstream kernel,

[   87.479859] be2net 0000:04:00.0: POST timeout; stage=0xc911
[   87.515978] be2net 0000:04:00.0: Emulex OneConnect
initialization failed
[   87.557130] be2net: probe of 0000:04:00.0 failed with error -1

lspci output,

04:00.0 Ethernet controller: Emulex Corporation OneConnect 10Gb NIC
(rev 02)
04:00.1 Ethernet controller: Emulex Corporation OneConnect 10Gb NIC
(rev 02)

04:00.1 Ethernet controller: Emulex Corporation OneConnect 10Gb NIC
(rev 02)
        Subsystem: Hewlett-Packard Company NC551i Dual Port
        FlexFabric 10Gb
Adapter

Confirmed no such problem using 3.7 kernel. Reproduced every time
and still
bisecting. Just want to give an early head-up to see if anyone saw
sometime
obvious.

Could you give me the FW version (ethtool -i) of the adapter (after
be2net successfully
probes in a 3.7 kernel.)

firmware-version: 2.104.281.0

If the FW version is as old as 2.x, then the culprit commit that
broke compatibility with old FW versions
on some (BE2) chips I is:
commit 1bc8e7e4f36c0c19dd7dea29e7c248b7c6ef3a15
be2net: fix access to SEMAPHORE reg

The fix for this is (still on David's net tree I guess):
commit c5b3ad4c67989c778e4753be4f91dc7193a04d21
be2net: use CSR-BAR SEMAPHORE reg for BE2/BE3

Dave, can these 2 commits be queued for stable too:
commit1: c5b3ad4c67989c778e4753be4f91dc7193a04d21
commit2: 1bc8e7e4f36c0c19dd7dea29e7c248b7c6ef3a15

thanks,
-Sathya