[PATCH v3] CAIF: fix sparse warning for caif_usb

Subsystems: networking [general], the rest

STALE4935d

2 messages, 2 authors, 2013-03-04 · open the first message on its own page

[PATCH v3] CAIF: fix sparse warning for caif_usb

From: Silviu-Mihai Popescu <hidden>
Date: 2013-03-04 07:09:36

This fixes the following sparse warning:
net/caif/caif_usb.c:84:16: warning: symbol 'cfusbl_create' was not
declared. Should it be static?

Signed-off-by: Silviu-Mihai Popescu <redacted>
---
 net/caif/caif_usb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c
index 3ebc8cb..1c6ded9 100644
--- a/net/caif/caif_usb.c
+++ b/net/caif/caif_usb.c
@@ -81,8 +81,8 @@ static void cfusbl_ctrlcmd(struct cflayer *layr, enum caif_ctrlcmd ctrl,
 		layr->up->ctrlcmd(layr->up, ctrl, layr->id);
 }
 
-struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
-					u8 braddr[ETH_ALEN])
+static struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
+				      u8 braddr[ETH_ALEN])
 {
 	struct cfusbl *this = kmalloc(sizeof(struct cfusbl), GFP_ATOMIC);
 
-- 
1.7.9.5

Re: [PATCH v3] CAIF: fix sparse warning for caif_usb

From: David Miller <davem@davemloft.net>
Date: 2013-03-04 19:15:39

From: Silviu-Mihai Popescu <redacted>
Date: Mon,  4 Mar 2013 09:09:31 +0200
This fixes the following sparse warning:
net/caif/caif_usb.c:84:16: warning: symbol 'cfusbl_create' was not
declared. Should it be static?

Signed-off-by: Silviu-Mihai Popescu <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help