[PATCH] caif_dev: fix sparse warnings for caif_flow_cb

Subsystems: networking [general], the rest

STALE4935d

2 messages, 2 authors, 2013-03-03 · open the first message on its own page

[PATCH] caif_dev: fix sparse warnings for caif_flow_cb

From: Silviu-Mihai Popescu <hidden>
Date: 2013-03-02 20:48:15

This fixed the following sparse warning:
net/caif/caif_dev.c:121:6: warning: symbol 'caif_flow_cb' was not
declared. Should it be static?

Signed-off-by: Silviu-Mihai Popescu <redacted>
---
 net/caif/caif_dev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
index 1ae1d9c..21760f0 100644
--- a/net/caif/caif_dev.c
+++ b/net/caif/caif_dev.c
@@ -118,7 +118,7 @@ static struct caif_device_entry *caif_get(struct net_device *dev)
 	return NULL;
 }
 
-void caif_flow_cb(struct sk_buff *skb)
+static void caif_flow_cb(struct sk_buff *skb)
 {
 	struct caif_device_entry *caifd;
 	void (*dtor)(struct sk_buff *skb) = NULL;
-- 
1.7.9.5

Re: [PATCH] caif_dev: fix sparse warnings for caif_flow_cb

From: David Miller <davem@davemloft.net>
Date: 2013-03-03 06:44:24

From: Silviu-Mihai Popescu <redacted>
Date: Sat,  2 Mar 2013 21:45:19 +0200
This fixed the following sparse warning:
net/caif/caif_dev.c:121:6: warning: symbol 'caif_flow_cb' was not
declared. Should it be static?

Signed-off-by: Silviu-Mihai Popescu <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help