Re: [PATCH 1/1] Fix dst_neigh_lookup/dst_neigh_lookup_skb return value handling bug

From: Zhouyi Zhou <hidden>
Date: 2013-03-14 05:55:15

Cong Wang [off-list ref]  wrote
quoted
 	neigh = dst_neigh_lookup(ep->dst,
 			&ep->com.cm_id->remote_addr.sin_addr.s_addr);
+	if (!neigh) {
+		pr_err("%s - cannot alloc neigh.\n", __func__);
+		err = -ENOMEM;
+		goto fail4;
You don't need to print error messages for OOM, the mm subsystem will
do.
Thanks for reviewing,  I clone these error messages print from the code
that follows:
   1612         if (!ep->l2t) {
   1613                 pr_err("%s - cannot alloc l2e.\n", __func__);
   1614                 err = -ENOMEM;
   1615                 goto fail4;
   1616         }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help