[PATCH] SUNRPC: Fix possible NULL pointer dereference
From: Syam Sidhardhan <hidden>
Date: 2013-02-24 22:23:39
Also in:
linux-nfs
Subsystem:
kernel nfsd, sunrpc, and lockd servers, networking [general], nfs, sunrpc, and lockd clients, the rest · Maintainers:
Chuck Lever, Jeff Layton, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Trond Myklebust, Anna Schumaker, Linus Torvalds
Check for cred == NULL has to be done before accessing cred. Signed-off-by: Syam Sidhardhan <redacted> --- net/sunrpc/auth.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
index f529404..18678a6 100644
--- a/net/sunrpc/auth.c
+++ b/net/sunrpc/auth.c@@ -695,10 +695,13 @@ rpcauth_invalcred(struct rpc_task *task) { struct rpc_cred *cred = task->tk_rqstp->rq_cred; + if (cred == NULL) + return; + dprintk("RPC: %5u invalidating %s cred %p\n", task->tk_pid, cred->cr_auth->au_ops->au_name, cred); - if (cred) - clear_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags); + + clear_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags); } int
--
1.7.9.5