Re: [PATCH net] tcp: Update MIB counters for drops
From: Eric Dumazet <hidden>
Date: 2013-01-30 23:39:14
On Wed, 2013-01-30 at 14:57 -0800, Vijay Subramanian wrote:
This patch updates LINUX_MIB_LISTENDROPS and LINUX_MIB_LISTENOVERFLOWS in tcp_v4_conn_request() and tcp_v4_err(). tcp_v4_conn_request() in particular can drop SYNs for various reasons which are not currently tracked. Signed-off-by: Vijay Subramanian <redacted> --- Ignored "line over 80 chars" warning for readability. net/ipv4/tcp_ipv4.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
quoted hunk ↗ jump to hunk
case TCP_SYN_SENT:@@ -1491,8 +1492,10 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb) */ if (inet_csk_reqsk_queue_is_full(sk) && !isn) { want_cookie = tcp_syn_flood_action(sk, skb, "TCP"); - if (!want_cookie) + if (!want_cookie) { + NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENOVERFLOWS); goto drop; + }
This should be done in tcp_syn_flood_action() for IPv4/IPv6 factorization.