[PATCH] ipv6: Fix endianess warning in ip6_flow_hdr().

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE4951d

2 messages, 2 authors, 2013-01-17 · open the first message on its own page

[PATCH] ipv6: Fix endianess warning in ip6_flow_hdr().

From: YOSHIFUJI Hideaki <hidden>
Date: 2013-01-17 03:10:58

Commit 3e4e4c1f ("ipv6: Introduce ip6_flow_hdr() to fill version,
tclass and flowlabel.) uses ntohl(), which should be htonl().

Found by Fengguang Wu [off-list ref].

Signed-off-by: YOSHIFUJI Hideaki <redacted>
---
 include/net/ipv6.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/ipv6.h b/include/net/ipv6.h
index 459a5a4..be3358b 100644
--- a/include/net/ipv6.h
+++ b/include/net/ipv6.h
@@ -629,7 +629,7 @@ extern void ipv6_select_ident(struct frag_hdr *fhdr, struct rt6_info *rt);
 static inline void ip6_flow_hdr(struct ipv6hdr *hdr, unsigned int tclass,
 				__be32 flowlabel)
 {
-	*(__be32 *)hdr = ntohl(0x60000000 | (tclass << 20)) | flowlabel;
+	*(__be32 *)hdr = htonl(0x60000000 | (tclass << 20)) | flowlabel;
 }
 
 static inline __be32 ip6_flowinfo(const struct ipv6hdr *hdr)
-- 
1.7.9.5

Re: [PATCH] ipv6: Fix endianess warning in ip6_flow_hdr().

From: David Miller <davem@davemloft.net>
Date: 2013-01-17 03:13:02

From: YOSHIFUJI Hideaki <redacted>
Date: Thu, 17 Jan 2013 12:10:57 +0900
Commit 3e4e4c1f ("ipv6: Introduce ip6_flow_hdr() to fill version,
tclass and flowlabel.) uses ntohl(), which should be htonl().

Found by Fengguang Wu [off-list ref].

Signed-off-by: YOSHIFUJI Hideaki <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help