cpts: Fix build error caused by include of plat/clock.h

5 messages, 4 authors, 2012-12-14 · open the first message on its own page

cpts: Fix build error caused by include of plat/clock.h

From: tony@atomide.com (Tony Lindgren)
Date: 2012-12-13 21:36:41

Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
mistakenly included plat/clock.h that should not be included by drivers
even if it exists.

Otherwise we get the following error with at least omap2plus_defconfig:

drivers/net/ethernet/ti/cpts.c:30:24: error: plat/clock.h: No such file or directory

Signed-off-by: Tony Lindgren <tony@atomide.com
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -27,8 +27,6 @@
 #include <linux/uaccess.h>
 #include <linux/workqueue.h>
 
-#include <plat/clock.h>
-
 #include "cpts.h"
 
 #ifdef CONFIG_TI_CPTS

cpts: Fix build error caused by include of plat/clock.h

From: richardcochran@gmail.com (Richard Cochran)
Date: 2012-12-14 07:13:00

On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
mistakenly included plat/clock.h that should not be included by drivers
even if it exists.
Hasn't this already been fixed?

  https://patchwork.kernel.org/patch/1810481/
  http://www.spinics.net/lists/linux-omap/msg83132.html

Thanks,
Richard

cpts: Fix build error caused by include of plat/clock.h

From: Koen Kooi <hidden>
Date: 2012-12-14 09:55:56

Op 14 dec. 2012, om 08:13 heeft Richard Cochran [off-list ref] het volgende geschreven:
On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
quoted
Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
mistakenly included plat/clock.h that should not be included by drivers
even if it exists.
Hasn't this already been fixed?

 https://patchwork.kernel.org/patch/1810481/
 http://www.spinics.net/lists/linux-omap/msg83132.html
That patch didn't get applied, so it's still broken in Linus' tree :(

regards,

Koen

cpts: Fix build error caused by include of plat/clock.h

From: richardcochran@gmail.com (Richard Cochran)
Date: 2012-12-14 11:09:18

On Fri, Dec 14, 2012 at 10:55:56AM +0100, Koen Kooi wrote:
Op 14 dec. 2012, om 08:13 heeft Richard Cochran [off-list ref] het volgende geschreven:
quoted
On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
quoted
Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
mistakenly included plat/clock.h that should not be included by drivers
even if it exists.
Hasn't this already been fixed?

 https://patchwork.kernel.org/patch/1810481/
 http://www.spinics.net/lists/linux-omap/msg83132.html
That patch didn't get applied, so it's still broken in Linus' tree :(
In netdev's patchwork, this was marked "Not Applicable." Dave, can you
possibly take this patch? If not, who should I ask next?

Thanks,
Richard

cpts: Fix build error caused by include of plat/clock.h

From: davem@davemloft.net (David Miller)
Date: 2012-12-14 18:18:39

From: Richard Cochran <richardcochran@gmail.com>
Date: Fri, 14 Dec 2012 12:09:18 +0100
On Fri, Dec 14, 2012 at 10:55:56AM +0100, Koen Kooi wrote:
quoted
Op 14 dec. 2012, om 08:13 heeft Richard Cochran [off-list ref] het volgende geschreven:
quoted
On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
quoted
Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware clock)
mistakenly included plat/clock.h that should not be included by drivers
even if it exists.
Hasn't this already been fixed?

 https://patchwork.kernel.org/patch/1810481/
 http://www.spinics.net/lists/linux-omap/msg83132.html
That patch didn't get applied, so it's still broken in Linus' tree :(
In netdev's patchwork, this was marked "Not Applicable." Dave, can you
possibly take this patch? If not, who should I ask next?
That's strange, when I look at that patch it's marked "Accepted" ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help