[PATCH] ipv6: addrconf.c: remove unnecessary "if"

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE4986d

2 messages, 2 authors, 2012-12-19 · open the first message on its own page

[PATCH] ipv6: addrconf.c: remove unnecessary "if"

From: Cong Ding <hidden>
Date: 2012-12-18 22:14:18

the value of err is always negative if it goes to errout, so we don't need to
check the value of err.

Signed-off-by: Cong Ding <redacted>
---
 net/ipv6/addrconf.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 6fca01f..408cac4a 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -534,8 +534,7 @@ void inet6_netconf_notify_devconf(struct net *net, int type, int ifindex,
 	rtnl_notify(skb, net, 0, RTNLGRP_IPV6_NETCONF, NULL, GFP_ATOMIC);
 	return;
 errout:
-	if (err < 0)
-		rtnl_set_sk_err(net, RTNLGRP_IPV6_NETCONF, err);
+	rtnl_set_sk_err(net, RTNLGRP_IPV6_NETCONF, err);
 }
 
 static const struct nla_policy devconf_ipv6_policy[NETCONFA_MAX+1] = {
-- 
1.7.10.4

Re: [PATCH] ipv6: addrconf.c: remove unnecessary "if"

From: David Miller <davem@davemloft.net>
Date: 2012-12-19 20:51:14

From: Cong Ding <redacted>
Date: Tue, 18 Dec 2012 23:08:56 +0100
the value of err is always negative if it goes to errout, so we don't need to
check the value of err.

Signed-off-by: Cong Ding <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help