[PATCH 08/12] bonding: do not cancel works in bond_uninit()

Subsystems: bonding driver, networking drivers, the rest

STALE4988d

2 messages, 2 authors, 2012-12-14 · open the first message on its own page

[PATCH 08/12] bonding: do not cancel works in bond_uninit()

From: Konstantin Khlebnikov <hidden>
Date: 2012-12-14 11:03:07

Bonding initializes these works in bond_open() and cancels in bond_close(),
thus in bond_uninit() they are already canceled but may be unitialized yet.

Signed-off-by: Konstantin Khlebnikov <redacted>
Cc: Nikolay Aleksandrov <redacted>
Cc: Jay Vosburgh <redacted>
Cc: Andy Gospodarek <andy@greyhouse.net>
Cc: netdev@vger.kernel.org
---
 drivers/net/bonding/bond_main.c |    2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index ef2cb24..b7d45f3 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4431,8 +4431,6 @@ static void bond_uninit(struct net_device *bond_dev)
 
 	list_del(&bond->bond_list);
 
-	bond_work_cancel_all(bond);
-
 	bond_debug_unregister(bond);
 
 	__hw_addr_flush(&bond->mc_list);

Re: [PATCH 08/12] bonding: do not cancel works in bond_uninit()

From: David Miller <davem@davemloft.net>
Date: 2012-12-14 18:16:23

From: Konstantin Khlebnikov <redacted>
Date: Fri, 14 Dec 2012 15:02:55 +0400
Bonding initializes these works in bond_open() and cancels in bond_close(),
thus in bond_uninit() they are already canceled but may be unitialized yet.

Signed-off-by: Konstantin Khlebnikov <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help