Sun, Dec 30, 2012 at 11:06:16PM CET, fbl@redhat.com wrote:

On Sun, Dec 30, 2012 at 10:47:23PM +0100, Jiri Pirko wrote:

quoted

Sun, Dec 30, 2012 at 07:27:29PM CET, fbl@redhat.com wrote:

quoted

Update master's carrier state when there is any
change with its ports.

This patch looks good to me. Just one nitpick I spotted....

quoted

+	bool team_linkup;
+
+	team_linkup = false;

This can be squashed together.

Ok, but that increases the static size of the module because it
moves the variable out of bss.

I have no strong opinion on either case, so it's up to you.

Ok :)

Acked-by: Jiri Pirko <jiri@resnulli.us>