[PATCH] skbuff: make __kmalloc_reserve static

STALE5002d

2 messages, 2 authors, 2012-12-29 · open the first message on its own page

[PATCH] skbuff: make __kmalloc_reserve static

From: Stephen Hemminger <hidden>
Date: 2012-12-29 04:25:49

Sparse detected case where this local function should be static.
It may even allow some compiler optimizations.

Signed-off-by: Stephen Hemminger <redacted>

--- a/net/core/skbuff.c	2012-12-28 19:46:31.967615872 -0800
+++ b/net/core/skbuff.c	2012-12-28 20:00:33.343165940 -0800
@@ -155,8 +155,9 @@ static void skb_under_panic(struct sk_bu
  */
 #define kmalloc_reserve(size, gfp, node, pfmemalloc) \
 	 __kmalloc_reserve(size, gfp, node, _RET_IP_, pfmemalloc)
-void *__kmalloc_reserve(size_t size, gfp_t flags, int node, unsigned long ip,
-			 bool *pfmemalloc)
+
+static void *__kmalloc_reserve(size_t size, gfp_t flags, int node,
+			       unsigned long ip, bool *pfmemalloc)
 {
 	void *obj;
 	bool ret_pfmemalloc = false;

Re: [PATCH] skbuff: make __kmalloc_reserve static

From: David Miller <davem@davemloft.net>
Date: 2012-12-29 04:33:16

From: Stephen Hemminger <redacted>
Date: Fri, 28 Dec 2012 20:24:28 -0800
Sparse detected case where this local function should be static.
It may even allow some compiler optimizations.

Signed-off-by: Stephen Hemminger <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help