[PATCH 1/2] drivers/net: Use of_match_ptr() macro in smc91x.c

Subsystems: networking drivers, smc91x ethernet driver, the rest

STALE5012d

4 messages, 2 authors, 2012-12-19 · open the first message on its own page

[PATCH 1/2] drivers/net: Use of_match_ptr() macro in smc91x.c

From: Sachin Kamat <hidden>
Date: 2012-12-19 11:53:50

This eliminates having an #ifdef returning NULL for the case
when OF is disabled.

Signed-off-by: Sachin Kamat <redacted>
---
Compile tested on linux-next.
---
 drivers/net/ethernet/smsc/smc91x.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 022b45b..a670d23 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c

@@ -2386,8 +2386,6 @@ static const struct of_device_id smc91x_match[] = {
 	{},
 };
 MODULE_DEVICE_TABLE(of, smc91x_match);
-#else
-#define smc91x_match NULL
 #endif
 
 static struct dev_pm_ops smc_drv_pm_ops = {

@@ -2402,7 +2400,7 @@ static struct platform_driver smc_driver = {
 		.name	= CARDNAME,
 		.owner	= THIS_MODULE,
 		.pm	= &smc_drv_pm_ops,
-		.of_match_table = smc91x_match,
+		.of_match_table = of_match_ptr(smc91x_match),
 	},
 };

-- 
1.7.4.1

[PATCH 2/2] drivers/net: Use of_match_ptr() macro in smsc911x.c

From: Sachin Kamat <hidden>
Date: 2012-12-19 11:30:58

Add CONFIG_OF guard and use of_match_ptr macro.

Signed-off-by: Sachin Kamat <redacted>
---
Compile tested on linux-next.
---
 drivers/net/ethernet/smsc/smsc911x.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 4616bf2..e112877 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c

@@ -2575,11 +2575,13 @@ static const struct dev_pm_ops smsc911x_pm_ops = {
 #define SMSC911X_PM_OPS NULL
 #endif
 
+#ifdef CONFIG_OF
 static const struct of_device_id smsc911x_dt_ids[] = {
 	{ .compatible = "smsc,lan9115", },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, smsc911x_dt_ids);
+#endif
 
 static struct platform_driver smsc911x_driver = {
 	.probe = smsc911x_drv_probe,

@@ -2588,7 +2590,7 @@ static struct platform_driver smsc911x_driver = {
 		.name	= SMSC_CHIPNAME,
 		.owner	= THIS_MODULE,
 		.pm	= SMSC911X_PM_OPS,
-		.of_match_table = smsc911x_dt_ids,
+		.of_match_table = of_match_ptr(smsc911x_dt_ids),
 	},
 };

-- 
1.7.4.1

Re: [PATCH 1/2] drivers/net: Use of_match_ptr() macro in smc91x.c

From: David Miller <davem@davemloft.net>
Date: 2012-12-19 20:50:30

From: Sachin Kamat <redacted>
Date: Wed, 19 Dec 2012 16:47:09 +0530

This eliminates having an #ifdef returning NULL for the case
when OF is disabled.

Signed-off-by: Sachin Kamat <redacted>

Applied.

Re: [PATCH 2/2] drivers/net: Use of_match_ptr() macro in smsc911x.c

From: David Miller <davem@davemloft.net>
Date: 2012-12-19 20:50:35

From: Sachin Kamat <redacted>
Date: Wed, 19 Dec 2012 16:47:10 +0530

Add CONFIG_OF guard and use of_match_ptr macro.

Signed-off-by: Sachin Kamat <redacted>

Applied.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help