[PATCH] bridge: Correctly encode addresses when dumping mdb entries

Subsystems: ethernet bridge, networking [general], the rest

STALE5011d

3 messages, 3 authors, 2012-12-19 · open the first message on its own page

[PATCH] bridge: Correctly encode addresses when dumping mdb entries

From: Vlad Yasevich <hidden>
Date: 2012-12-18 21:54:17

When dumping mdb table, set the addresses the kernel returns
based on the address protocol type.

Signed-off-by: Vlad Yasevich <redacted>
---
 net/bridge/br_mdb.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index 9cf5d2b..ac22bb2 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -84,9 +84,11 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb,
 					struct br_mdb_entry e;
 					e.ifindex = port->dev->ifindex;
 					e.state = p->state;
-					e.addr.u.ip4 = p->addr.u.ip4;
+					if (p->addr.proto == htons(ETH_P_IP))
+						e.addr.u.ip4 = p->addr.u.ip4;
 #if IS_ENABLED(CONFIG_IPV6)
-					e.addr.u.ip6 = p->addr.u.ip6;
+					if (p->addr.proto == htons(ETH_P_IPV6))
+						e.addr.u.ip6 = p->addr.u.ip6;
 #endif
 					e.addr.proto = p->addr.proto;
 					if (nla_put(skb, MDBA_MDB_ENTRY_INFO, sizeof(e), &e)) {
-- 
1.7.7.6

Re: [PATCH] bridge: Correctly encode addresses when dumping mdb entries

From: Cong Wang <hidden>
Date: 2012-12-19 07:11:42

On Tue, 18 Dec 2012 at 21:54 GMT, Vlad Yasevich [off-list ref] wrote:
When dumping mdb table, set the addresses the kernel returns
based on the address protocol type.

Signed-off-by: Vlad Yasevich <redacted>
Looks good.

Acked-by: Cong Wang <redacted>

Re: [PATCH] bridge: Correctly encode addresses when dumping mdb entries

From: David Miller <davem@davemloft.net>
Date: 2012-12-19 20:50:58

From: Vlad Yasevich <redacted>
Date: Tue, 18 Dec 2012 16:54:08 -0500
When dumping mdb table, set the addresses the kernel returns
based on the address protocol type.

Signed-off-by: Vlad Yasevich <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help