[PATCH net-next] net: gro: avoid double copy in skb_gro_receive()

Subsystems: networking [general], the rest

STALE5019d

2 messages, 2 authors, 2012-12-11 · open the first message on its own page

[PATCH net-next] net: gro: avoid double copy in skb_gro_receive()

From: Eric Dumazet <hidden>
Date: 2012-12-11 18:38:32

From: Eric Dumazet <edumazet@google.com>

__copy_skb_header(nskb, p) already copied p->cb[], no need to copy
it again.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/core/skbuff.c |    1 -
 1 file changed, 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index ccbabf5..ac9e44a 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -3028,7 +3028,6 @@ int skb_gro_receive(struct sk_buff **head, struct sk_buff *skb)
 	memcpy(skb_mac_header(nskb), skb_mac_header(p),
 	       p->data - skb_mac_header(p));
 
-	*NAPI_GRO_CB(nskb) = *NAPI_GRO_CB(p);
 	skb_shinfo(nskb)->frag_list = p;
 	skb_shinfo(nskb)->gso_size = pinfo->gso_size;
 	pinfo->gso_size = 0;

Re: [PATCH net-next] net: gro: avoid double copy in skb_gro_receive()

From: David Miller <davem@davemloft.net>
Date: 2012-12-11 18:45:20

From: Eric Dumazet <redacted>
Date: Tue, 11 Dec 2012 10:38:29 -0800
From: Eric Dumazet <edumazet@google.com>

__copy_skb_header(nskb, p) already copied p->cb[], no need to copy
it again.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help