[PATCH -next] net: neterion: use for_each_pci_dev to simplify the code

Subsystems: networking drivers, the rest

STALE5006d

2 messages, 2 authors, 2012-12-04 · open the first message on its own page

[PATCH -next] net: neterion: use for_each_pci_dev to simplify the code

From: Wei Yongjun <hidden>
Date: 2012-12-04 05:05:13

From: Wei Yongjun <redacted>

Use for_each_pci_dev to simplify the code.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/neterion/s2io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c
index c98decb..3b63504 100644
--- a/drivers/net/ethernet/neterion/s2io.c
+++ b/drivers/net/ethernet/neterion/s2io.c
@@ -1040,7 +1040,7 @@ static int s2io_verify_pci_mode(struct s2io_nic *nic)
 static int s2io_on_nec_bridge(struct pci_dev *s2io_pdev)
 {
 	struct pci_dev *tdev = NULL;
-	while ((tdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, tdev)) != NULL) {
+	for_each_pci_dev(tdev) {
 		if (tdev->vendor == NEC_VENID && tdev->device == NEC_DEVID) {
 			if (tdev->bus == s2io_pdev->bus->parent) {
 				pci_dev_put(tdev);

Re: [PATCH -next] net: neterion: use for_each_pci_dev to simplify the code

From: David Miller <davem@davemloft.net>
Date: 2012-12-04 18:20:09

From: Wei Yongjun <redacted>
Date: Tue, 4 Dec 2012 00:05:13 -0500
From: Wei Yongjun <redacted>

Use for_each_pci_dev to simplify the code.

Signed-off-by: Wei Yongjun <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help