[PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion

Subsystems: marvell mvneta ethernet driver, networking drivers, the rest

STALE4956d

4 messages, 3 authors, 2013-01-17 · open the first message on its own page

[PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion

From: Sachin Kamat <hidden>
Date: 2012-12-03 09:52:12

linux/version.h inclusion is not necessary.

Signed-off-by: Sachin Kamat <redacted>
---
 drivers/net/ethernet/marvell/mvneta.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 3f8086b..a1e0e9f 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -12,7 +12,6 @@
  */
 
 #include <linux/kernel.h>
-#include <linux/version.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
 #include <linux/platform_device.h>
-- 
1.7.4.1

Re: [PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion

From: David Miller <davem@davemloft.net>
Date: 2012-12-03 18:46:22

From: Sachin Kamat <redacted>
Date: Mon,  3 Dec 2012 15:15:28 +0530
linux/version.h inclusion is not necessary.

Signed-off-by: Sachin Kamat <redacted>
Acked-by: David S. Miller <davem@davemloft.net>

I hope the mvneta folks will pick this up and apply it where it
needs to be as the mvneta driver isn't in the net-next tree.

Re: [PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion

From: Thomas Petazzoni <hidden>
Date: 2012-12-03 18:58:41

Dear David Miller,

On Mon, 03 Dec 2012 13:46:20 -0500 (EST), David Miller wrote:
From: Sachin Kamat <redacted>
Date: Mon,  3 Dec 2012 15:15:28 +0530
quoted
linux/version.h inclusion is not necessary.

Signed-off-by: Sachin Kamat <redacted>
Acked-by: David S. Miller <davem@davemloft.net>

I hope the mvneta folks will pick this up and apply it where it
needs to be as the mvneta driver isn't in the net-next tree.
Yes, I will pick it up, and send a pull request to the Marvell
maintainers. I have other mvneta fixes that I'll send together with
this one.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion

From: Sachin Kamat <hidden>
Date: 2013-01-17 03:00:11

Hi Thomas,

On 4 December 2012 00:28, Thomas Petazzoni
[off-list ref] wrote:
Dear David Miller,

On Mon, 03 Dec 2012 13:46:20 -0500 (EST), David Miller wrote:
quoted
From: Sachin Kamat <redacted>
Date: Mon,  3 Dec 2012 15:15:28 +0530
quoted
linux/version.h inclusion is not necessary.

Signed-off-by: Sachin Kamat <redacted>
Acked-by: David S. Miller <davem@davemloft.net>

I hope the mvneta folks will pick this up and apply it where it
needs to be as the mvneta driver isn't in the net-next tree.
Yes, I will pick it up, and send a pull request to the Marvell
maintainers. I have other mvneta fixes that I'll send together with
this one.
Can you please share the git repo link where this patch is lined up ATM?

Thanks,

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


-- 
With warm regards,
Sachin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help