[PATCH net-next,1/1] hyperv: Add an error message to rndis_filter_set_device_mac()

Subsystems: hyper-v/azure core and drivers, networking drivers, the rest

STALE5009d REVIEWED: 1 (1M)

1 review trailer (1 from subsystem maintainers).

2 messages, 2 authors, 2012-11-30 · open the first message on its own page

[PATCH net-next,1/1] hyperv: Add an error message to rndis_filter_set_device_mac()

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2012-11-30 19:00:57

This message indicates an error returned from the host when changing MAC address.

Reported-by: Michal Kubecek <redacted>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>

---
 drivers/net/hyperv/rndis_filter.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 7fdeb52..2b657d4 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -605,8 +605,11 @@ int rndis_filter_set_device_mac(struct hv_device *hdev, char *mac)
 		return -EBUSY;
 	} else {
 		set_complete = &request->response_msg.msg.set_complete;
-		if (set_complete->status != RNDIS_STATUS_SUCCESS)
+		if (set_complete->status != RNDIS_STATUS_SUCCESS) {
+			netdev_err(ndev, "Fail to set MAC on host side:0x%x\n",
+				   set_complete->status);
 			ret = -EINVAL;
+		}
 	}
 
 cleanup:
-- 
1.7.4.1

Re: [PATCH net-next,1/1] hyperv: Add an error message to rndis_filter_set_device_mac()

From: David Miller <davem@davemloft.net>
Date: 2012-11-30 20:03:12

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri, 30 Nov 2012 11:23:41 -0800
This message indicates an error returned from the host when changing MAC address.

Reported-by: Michal Kubecek <redacted>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help