Latest 3.6.6 are not compiling due tg3 network driver,hwmon_device_unregister

9 messages, 4 authors, 2012-11-19 · open the first message on its own page

Latest 3.6.6 are not compiling due tg3 network driver,hwmon_device_unregister

From: Denys Fedoryshchenko <hidden>
Date: 2012-11-15 03:03:56

Hi

During compiling i am getting that:

drivers/built-in.o: In function `tg3_close':
tg3.c:(.text+0x12902e): undefined reference to 
`hwmon_device_unregister'
drivers/built-in.o: In function `tg3_hwmon_open':
tg3.c:(.text+0x12ae09): undefined reference to `hwmon_device_register'

Kernel config are at http://nuclearcat.com/config-tg3.txt  , but i 
noticed this error are appearing at x86, x64 kernels, probably also 
other 3.6.x series kernels.
Disabling TG3 driver helps, but i believe it is not a solution.

---
Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L.

Re: Latest 3.6.6 are not compiling due tg3 network driver, hwmon_device_unregister

From: Nithin Nayak Sujir <hidden>
Date: 2012-11-15 03:24:39

This was fixed by

commit de0a41484c47d783dd4d442914815076aa2caac2
Author: Paul Gortmaker [off-list ref]
Date:   Mon Oct 1 11:43:49 2012 -0400

     tg3: unconditionally select HWMON support when tg3 is enabled.


Nithin.


On 11/14/2012 07:03 PM, Denys Fedoryshchenko wrote:
Hi

During compiling i am getting that:

drivers/built-in.o: In function `tg3_close':
tg3.c:(.text+0x12902e): undefined reference to `hwmon_device_unregister'
drivers/built-in.o: In function `tg3_hwmon_open':
tg3.c:(.text+0x12ae09): undefined reference to `hwmon_device_register'

Kernel config are at http://nuclearcat.com/config-tg3.txt  , but i noticed this error are 
appearing at x86, x64 kernels, probably also other 3.6.x series kernels.
Disabling TG3 driver helps, but i believe it is not a solution.

---
Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L.
-- 
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Latest 3.6.6 are not compiling due tg3 network driver, hwmon_device_unregister

From: David Rientjes <rientjes@google.com>
Date: 2012-11-15 03:30:34

On Wed, 14 Nov 2012, Nithin Nayak Sujir wrote:
This was fixed by

commit de0a41484c47d783dd4d442914815076aa2caac2
Author: Paul Gortmaker [off-list ref]
Date:   Mon Oct 1 11:43:49 2012 -0400

    tg3: unconditionally select HWMON support when tg3 is enabled.
Would you mind submitting this for stable by following the procedure 
described in Documentation/stable_kernel_rules.txt?

Re: Latest 3.6.6 are not compiling due tg3 network driver, hwmon_device_unregister

From: Nithin Nayak Sujir <hidden>
Date: 2012-11-15 03:43:40

On 11/14/2012 07:30 PM, David Rientjes wrote:
On Wed, 14 Nov 2012, Nithin Nayak Sujir wrote:
quoted
This was fixed by

commit de0a41484c47d783dd4d442914815076aa2caac2
Author: Paul Gortmaker [off-list ref]
Date:   Mon Oct 1 11:43:49 2012 -0400

     tg3: unconditionally select HWMON support when tg3 is enabled.
Would you mind submitting this for stable by following the procedure
described in Documentation/stable_kernel_rules.txt?
Will do. Thank you for bringing this to our attention.

Nithin.

RE: Latest 3.6.6 are not compiling due tg3 network driver, hwmon_device_unregister

From: Nithin Sujir <hidden>
Date: 2012-11-15 07:22:36

-----Original Message-----
From: David Rientjes [mailto:rientjes@google.com]
Sent: Wednesday, November 14, 2012 7:31 PM
To: Nithin Sujir; Paul Gortmaker
Cc: Denys Fedoryshchenko; Michael Chan; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org
Subject: Re: Latest 3.6.6 are not compiling due tg3 network driver,
hwmon_device_unregister

On Wed, 14 Nov 2012, Nithin Nayak Sujir wrote:
quoted
This was fixed by

commit de0a41484c47d783dd4d442914815076aa2caac2
Author: Paul Gortmaker [off-list ref]
Date:   Mon Oct 1 11:43:49 2012 -0400

    tg3: unconditionally select HWMON support when tg3 is enabled.
Would you mind submitting this for stable by following the procedure
described in Documentation/stable_kernel_rules.txt?

Seems to have been taken into stable already. 
http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=commitdiff;h=aecdc33e111b2c447b622e287c6003726daa1426

Nithin.

RE: Latest 3.6.6 are not compiling due tg3 network driver, hwmon_device_unregister

From: David Rientjes <rientjes@google.com>
Date: 2012-11-15 07:51:20

On Thu, 15 Nov 2012, Nithin Sujir wrote:
quoted
Would you mind submitting this for stable by following the procedure
described in Documentation/stable_kernel_rules.txt?

Seems to have been taken into stable already. 
http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=commitdiff;h=aecdc33e111b2c447b622e287c6003726daa1426
You're looking at the wrong shortlog (that's 3.7-rc4, not a stable tree), 
you'll want to backport this on top of 3.6.6 and send it to 
stable@vger.kernel.org following the procedure in 
Documentation/stable_kernel_rules.txt.

Re: Latest 3.6.6 are not compiling due tg3 network driver, hwmon_device_unregister

From: Mathias Krause <hidden>
Date: 2012-11-15 08:04:06

On Thu, Nov 15, 2012 at 07:22:20AM +0000, Nithin Sujir wrote:
quoted
On Wed, 14 Nov 2012, Nithin Nayak Sujir wrote:
quoted
This was fixed by

commit de0a41484c47d783dd4d442914815076aa2caac2
Author: Paul Gortmaker [off-list ref]
Date:   Mon Oct 1 11:43:49 2012 -0400

    tg3: unconditionally select HWMON support when tg3 is enabled.
Would you mind submitting this for stable by following the procedure
described in Documentation/stable_kernel_rules.txt?

Seems to have been taken into stable already. 
http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=commitdiff;h=aecdc33e111b2c447b622e287c6003726daa1426
No, it's not. That's the merge commit for the v3.7 merge window.

Compare this:

 $ git log --oneline --grep='tg3.*HWMON' v3.6..origin/master
 aecdc33 Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
 de0a414 tg3: unconditionally select HWMON support when tg3 is enabled.

to this:

 $ git log --oneline --grep='tg3.*HWMON' v3.6..stable/linux-3.6.y

No tg3 fix in the v3.6 stable series. But Dave may has queued it already?


Mathias

Re: Latest 3.6.6 are not compiling due tg3 network driver, hwmon_device_unregister

From: David Rientjes <rientjes@google.com>
Date: 2012-11-18 22:42:53

On Wed, 14 Nov 2012, Nithin Nayak Sujir wrote:
On 11/14/2012 07:30 PM, David Rientjes wrote:
quoted
On Wed, 14 Nov 2012, Nithin Nayak Sujir wrote:
quoted
This was fixed by

commit de0a41484c47d783dd4d442914815076aa2caac2
Author: Paul Gortmaker [off-list ref]
Date:   Mon Oct 1 11:43:49 2012 -0400

     tg3: unconditionally select HWMON support when tg3 is enabled.
Would you mind submitting this for stable by following the procedure
described in Documentation/stable_kernel_rules.txt?
Will do. Thank you for bringing this to our attention.
Thanks for submitting the patch to stable, Greg has queued it for the 
kernels he maintains.  Denys, expect to see this fix in 3.6.8.

Re: Latest 3.6.6 are not compiling due tg3 network driver,hwmon_device_unregister

From: Denys Fedoryshchenko <hidden>
Date: 2012-11-19 06:59:44

On 2012-11-19 00:42, David Rientjes wrote:
On Wed, 14 Nov 2012, Nithin Nayak Sujir wrote:
quoted
On 11/14/2012 07:30 PM, David Rientjes wrote:
quoted
On Wed, 14 Nov 2012, Nithin Nayak Sujir wrote:
quoted
This was fixed by

commit de0a41484c47d783dd4d442914815076aa2caac2
Author: Paul Gortmaker [off-list ref]
Date:   Mon Oct 1 11:43:49 2012 -0400

     tg3: unconditionally select HWMON support when tg3 is 
enabled.
quoted
quoted
Would you mind submitting this for stable by following the 
procedure
quoted
described in Documentation/stable_kernel_rules.txt?
Will do. Thank you for bringing this to our attention.
Thanks for submitting the patch to stable, Greg has queued it for the
kernels he maintains.  Denys, expect to see this fix in 3.6.8.
Thank you!

---
Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help